Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request skip no results message #20

Closed
gator92 opened this issue Nov 6, 2012 · 5 comments
Closed

Feature request skip no results message #20

gator92 opened this issue Nov 6, 2012 · 5 comments
Labels

Comments

@gator92
Copy link

gator92 commented Nov 6, 2012

Sometimes the no results message is cumbersome, would be nice to have an option for this. Eg, in the jquery version no_results function, a flag to show the no results message:

if(!this.skip_no_results){
    var no_results_html;
    ...
    this.search_results.append(no_results_html);
}

This would probably only make sense if create_option were true, ie, this.skip_no_results = (this.options.skip_no_results || false) && this.create_option;

@chadwhitacre
Copy link

+1

Having both messages seems redundant to me.

screen shot 2013-04-30 at 9 34 07 am

@koenpunt
Copy link
Owner

Will look into this soon. PR is welcome

@gator92
Copy link
Author

gator92 commented May 1, 2013

Thanks, will make a PR when/if I get the time to deal with coffescript.

@koenpunt
Copy link
Owner

@gator92 As you may have noticed; I've implemented your suggestion

@gator92
Copy link
Author

gator92 commented May 13, 2013

@koenpunt Thank you very much! This feature along with the essential create_option callback makes this the most useful js combo box available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants