Feature request skip no results message #20

Closed
Gator92 opened this Issue Nov 6, 2012 · 5 comments

Comments

Projects
None yet
3 participants
@Gator92

Gator92 commented Nov 6, 2012

Sometimes the no results message is cumbersome, would be nice to have an option for this. Eg, in the jquery version no_results function, a flag to show the no results message:

if(!this.skip_no_results){
    var no_results_html;
    ...
    this.search_results.append(no_results_html);
}

This would probably only make sense if create_option were true, ie, this.skip_no_results = (this.options.skip_no_results || false) && this.create_option;

@chadwhitacre

This comment has been minimized.

Show comment Hide comment
@chadwhitacre

chadwhitacre Apr 30, 2013

+1

Having both messages seems redundant to me.

screen shot 2013-04-30 at 9 34 07 am

+1

Having both messages seems redundant to me.

screen shot 2013-04-30 at 9 34 07 am

@koenpunt

This comment has been minimized.

Show comment Hide comment
@koenpunt

koenpunt Apr 30, 2013

Owner

Will look into this soon. PR is welcome

Owner

koenpunt commented Apr 30, 2013

Will look into this soon. PR is welcome

@Gator92

This comment has been minimized.

Show comment Hide comment
@Gator92

Gator92 May 1, 2013

Thanks, will make a PR when/if I get the time to deal with coffescript.

Gator92 commented May 1, 2013

Thanks, will make a PR when/if I get the time to deal with coffescript.

@koenpunt koenpunt closed this in 5caba79 May 12, 2013

@koenpunt

This comment has been minimized.

Show comment Hide comment
@koenpunt

koenpunt May 13, 2013

Owner

@Gator92 As you may have noticed; I've implemented your suggestion

Owner

koenpunt commented May 13, 2013

@Gator92 As you may have noticed; I've implemented your suggestion

@Gator92

This comment has been minimized.

Show comment Hide comment
@Gator92

Gator92 May 13, 2013

@koenpunt Thank you very much! This feature along with the essential create_option callback makes this the most useful js combo box available.

Gator92 commented May 13, 2013

@koenpunt Thank you very much! This feature along with the essential create_option callback makes this the most useful js combo box available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment