This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Added check to only attempt loading rules and routes after the ufw is installed #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZloeSabo
force-pushed
the
bugfix/load-resources-only-after-ufw-installed
branch
2 times, most recently
from
96bc01a
to
5db37c8
Compare
…talled Signed-off-by: Evgeny Soynov <esoynov@kogito.network>
ZloeSabo
force-pushed
the
bugfix/load-resources-only-after-ufw-installed
branch
from
5db37c8
to
4aec466
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to return an empty list of rules and routes if corresponding resources are running before the UFW is installed.
The resource metatype seem to ignore the ordering a attempts to load rules and routes at the beginning of every run. Perhaps this behavior is made on purpose to allow puppet to calculate a diff properly to purge unmanaged resources. But at the same time, it causes issues when puppet attempts to fetch the list before UFW package is installed.