Call mkdir and file_put_contents once to improve performance
#649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Returns early if there's nothing to write - Call `mkdir` once with recursive flag on - Prepare string to write and call `file_put_contents` once
enov
force-pushed
the
3.4/feature/log-writer-file-performance
branch
from
1242079
to
b3bbbd1
Compare
|
On Travis CI, composer can't finish updating packages for HHVM, as well as in kohana/image#28 for all runtimes. Is this related to composer/composer#1314? |
acoulton
added a commit
that referenced
this pull request
Dec 16, 2015
As reported in #649, some travis builds are failing to install composer packages - this appears to be since we added package caching. travis-ci/travis-ci#4579 (comment) suggests only caching composer's cached package archives, not metadata and the checked out vendors, which may themselves be out of date. Also try running with the --no-interaction flag, which should trigger it to fall back to a git checkout when the travis API token has been rate limited.
acoulton
added a commit
that referenced
this pull request
Dec 16, 2015
…rmance Call `mkdir` and `file_put_contents` once to improve performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkdironce with recursive flag onfile_put_contentsonceThanks.