Skip to content
Browse files

Switching submodules from git:// to http://

  • Loading branch information...
1 parent 04b5377 commit 1a0a0b52ce24b5c5051e8a4de0094140e4e521ca @kiall kiall committed Jan 14, 2011
Showing with 9 additions and 9 deletions.
  1. +9 −9 .gitmodules
View
18 .gitmodules
@@ -1,27 +1,27 @@
[submodule "system"]
path = system
- url = git://github.com/kohana/core.git
+ url = http://github.com/kohana/core.git
[submodule "modules/codebench"]
path = modules/codebench
- url = git://github.com/kohana/codebench.git
+ url = http://github.com/kohana/codebench.git
[submodule "modules/database"]
path = modules/database
- url = git://github.com/kohana/database.git
+ url = http://github.com/kohana/database.git
[submodule "modules/image"]
path = modules/image
- url = git://github.com/kohana/image.git
+ url = http://github.com/kohana/image.git
[submodule "modules/orm"]
path = modules/orm
- url = git://github.com/kohana/orm.git
+ url = http://github.com/kohana/orm.git
[submodule "modules/auth"]
path = modules/auth
- url = git://github.com/kohana/auth.git
+ url = http://github.com/kohana/auth.git
[submodule "modules/userguide"]
path = modules/userguide
- url = git://github.com/kohana/userguide.git
+ url = http://github.com/kohana/userguide.git
[submodule "modules/cache"]
path = modules/cache
- url = git://github.com/kohana/cache.git
+ url = http://github.com/kohana/cache.git
[submodule "modules/unittest"]
path = modules/unittest
- url = git://github.com/kohana/unittest.git
+ url = http://github.com/kohana/unittest.git

10 comments on commit 1a0a0b5

@glamorous

Is there a reason why this is changed?

@biakaveron
Kohana PHP Framework member

For example, msysgit on Windows doesnt work with git:// URLs. Anyway, developer links are still with git://

@kiall
kiall commented on 1a0a0b5 Apr 18, 2011

msysgit doesn't work with git:// urls? I'm 99.9% sure it does .. anyway!

There were changed for three reasons 1) Github is pushing people to use the http URLs.. (HTTP can be easily cached, git:// can't) ... 2) Some people have noticed a speed difference between http and git and 3) Lame corporate firewalls blocking the git:// port .. (I've hit that one with at least two clients!)

@smgladkovskiy

Or, maybe https is needed? :)

@kiall
kiall commented on 1a0a0b5 Apr 18, 2011

HTTP works just fine - why add the overhead of SSL? .. its not like you're cloning corporate secrets .. its open source!

@smgladkovskiy

Hmm... When GitHub switched its work on HTTPS, I had 404 errors when was trying to clone repo via HTTP. May be something changed now.
However, even GitHub is pushing to use https (or git) urls in project url copying widget.

@kiall
kiall commented on 1a0a0b5 Apr 18, 2011

HTTP is definitely supported - this suggests using HTTP rather than HTTPS for public repos ... https://github.com/blog/642-smart-http-support

Chances are your 404 errors were due to trying to clone without the .git .. eg

This: $ git clone http://github.com/kohana/kohana

Rather than: $ git clone http://github.com/kohana/kohana.git

@zombor
Kohana PHP Framework member
@kiall
kiall commented on 1a0a0b5 Apr 18, 2011

As far as i know HTTPS is being pushed due to HTTP session hijacking .. I'm not convinced thats an issue when it comes to doing a git clone .. That doesn't explain the default "clone url" being https tho ..

Either way .. I get those invalid cert's messages with HTTPs as well... I see no reason to change it to HTTPS when HTTP works "better"...

@glamorous

Thank you for the massive responses ;-)

Please sign in to comment.
Something went wrong with that request. Please try again.