Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Feature/cleanup #53

Merged
merged 7 commits into from Mar 6, 2012

Conversation

Projects
None yet
4 participants
Member

Zeelot commented Feb 28, 2012

Just trying to clean things up and match a little closer to what they used to be.

  • Removed last Util methods. Had to keep a couple static ones for now but at least they are all in Minion_Task where they belong
  • Validation method for valid options was also moved to Minion_Task as it's not useful anywhere else
  • $_options is now a $option => $default array and defines the accepted options
  • Moved static method/property order to match all our other code (we should discuss official conventions)
  • Removed any left over notion of config since everything is options now
Member

Zeelot commented Feb 28, 2012

@kiall could you give this a quick look? I think I am ok with minion being released in this state (would like to get rid of more static functions down the road)

Build Scheduled

Member

Zeelot commented Feb 28, 2012

Guess I'll try fixing the build tomorrow ;) probably broken unit tests

Contributor

kiall commented Feb 28, 2012

Re the build failure.. From http://ci.kohanaframework.org/job/kohana-3.3-pull/64/consoleFull

PHP Fatal error:  Class 'Minion_Util' not found in /var/lib/jenkins/jobs/kohana-3.3-pull/workspace/modules/minion/tests/minion/util.php on line 48

Re the pull itself.. Looks good. Let's get this merged once the tests are sorted :)

Member

Zeelot commented Mar 6, 2012

!build

Build Scheduled

Build Scheduled

@Zeelot Zeelot added a commit that referenced this pull request Mar 6, 2012

@Zeelot Zeelot Merge pull request #53 from kohana/feature/cleanup
Feature/cleanup
8716cfe

@Zeelot Zeelot merged commit 8716cfe into 3.3/develop Mar 6, 2012

Member

biakaveron commented Mar 16, 2012

Task_Help class still uses Minion_Util.

Member

Zeelot commented Mar 17, 2012

Thanks I'll take a look!

Member

biakaveron commented Mar 17, 2012

See #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment