pull request for #54 issue #55

Merged
merged 3 commits into from Mar 18, 2012

Conversation

Projects
None yet
3 participants
@biakaveron
Member

biakaveron commented Mar 16, 2012

No description provided.

@Kohana-Builds

This comment has been minimized.

Show comment Hide comment
@Kohana-Builds

Kohana-Builds Mar 16, 2012

Build Scheduled

Build Scheduled

@Kohana-Builds

This comment has been minimized.

Show comment Hide comment
@Zeelot

View changes

classes/Task/Help.php
@@ -17,7 +17,7 @@ class Task_Help extends Minion_Task
*/
protected function _execute(array $params)
{
- $tasks = Minion_Util::compile_task_list(Kohana::list_files('classes/Task'));
+ $tasks = self::compile_task_list(Kohana::list_files('classes/Task'));

This comment has been minimized.

Show comment Hide comment
@Zeelot

Zeelot Mar 18, 2012

Member

Could you change this to Minion_Task::compile_task_list()? Seems that is our convention.

@Zeelot

Zeelot Mar 18, 2012

Member

Could you change this to Minion_Task::compile_task_list()? Seems that is our convention.

This comment has been minimized.

Show comment Hide comment
@biakaveron

biakaveron Mar 18, 2012

Member

Done

@Kohana-Builds

This comment has been minimized.

Show comment Hide comment
@Kohana-Builds

Kohana-Builds Mar 18, 2012

Build Scheduled

Build Scheduled

@Kohana-Builds

This comment has been minimized.

Show comment Hide comment

Zeelot added a commit that referenced this pull request Mar 18, 2012

@Zeelot Zeelot merged commit 965e521 into kohana:3.3/develop Mar 18, 2012

@biakaveron

This comment has been minimized.

Show comment Hide comment
@biakaveron

biakaveron Mar 21, 2012

Member

Well, I dont know, where I got a Minion_Task::compile_task_list() method, but there is no such method )) It must be $this->_compile_task_list(). Should I create a new pull request?

PS. Sorry for wasting your time (confused)

Member

biakaveron commented Mar 21, 2012

Well, I dont know, where I got a Minion_Task::compile_task_list() method, but there is no such method )) It must be $this->_compile_task_list(). Should I create a new pull request?

PS. Sorry for wasting your time (confused)

@Zeelot

This comment has been minimized.

Show comment Hide comment
@Zeelot

Zeelot Mar 22, 2012

Member

No worries, my fault. Fixing this now.

Member

Zeelot commented Mar 22, 2012

No worries, my fault. Fixing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment