Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

pull request for #54 issue #55

Merged
merged 3 commits into from

3 participants

@biakaveron

No description provided.

@Kohana-Builds
Collaborator

Build Scheduled

classes/Task/Help.php
@@ -17,7 +17,7 @@ class Task_Help extends Minion_Task
*/
protected function _execute(array $params)
{
- $tasks = Minion_Util::compile_task_list(Kohana::list_files('classes/Task'));
+ $tasks = self::compile_task_list(Kohana::list_files('classes/Task'));
@Zeelot Owner
Zeelot added a note

Could you change this to Minion_Task::compile_task_list()? Seems that is our convention.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Kohana-Builds
Collaborator

Build Scheduled

@Zeelot Zeelot merged commit 965e521 into kohana:3.3/develop
@biakaveron

Well, I dont know, where I got a Minion_Task::compile_task_list() method, but there is no such method )) It must be $this->_compile_task_list(). Should I create a new pull request?

PS. Sorry for wasting your time (confused)

@Zeelot
Owner

No worries, my fault. Fixing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 16, 2012
  1. @biakaveron

    fixing #54

    biakaveron authored
  2. @biakaveron
Commits on Mar 18, 2012
  1. @biakaveron
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +1 −1  classes/Kohana/Minion/Task.php
  2. +1 −1  classes/Task/Help.php
View
2  classes/Kohana/Minion/Task.php
@@ -266,7 +266,7 @@ public function valid_option(Validation $validation, $option)
{
if ( ! in_array($option, $this->_accepted_options))
{
- $validation->error($key, 'minion_option');
+ $validation->error($option, 'minion_option');
}
}
View
2  classes/Task/Help.php
@@ -17,7 +17,7 @@ class Task_Help extends Minion_Task
*/
protected function _execute(array $params)
{
- $tasks = Minion_Util::compile_task_list(Kohana::list_files('classes/Task'));
+ $tasks = Minion_Task::compile_task_list(Kohana::list_files('classes/Task'));
$view = new View('minion/help/list');
Something went wrong with that request. Please try again.