Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes #4290 - Automatically creating tokens only when a token isn't set #41

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

gevans commented Oct 3, 2011

Also, not 100% sure this is something that should be applied to 3.2/develop or held off until there's a 3.3 branch.

Jenkins Build Starting

gevans commented Oct 31, 2011

Nice.

22:12:48  There was 1 failure:
22:12:48  
22:12:48  1) Kohana_Cache_FileTest::test_set_get with data set #6 (array('object', stdClass, 0, false, 'object', NULL), stdClass)
22:12:48  Failed asserting that <null> is equal to 
22:12:48  stdClass Object
22:12:48  (
22:12:48      [foo] => foo
22:12:48      [bar] => bar
22:12:48  )
Contributor

kiall commented Oct 31, 2011

Humm .. looks like a bug in the cache tests triggered this to fail...

!build

Jenkins Build Starting

@kemo kemo commented on the diff Apr 11, 2014

classes/model/auth/user/token.php
public function create(Validation $validation = NULL)
{
- $this->token = $this->create_token();
+ if ($this->token === NULL OR ORM::factory('user_token', array('token' => $token))->loaded())
+ {
@kemo

kemo Apr 11, 2014

Member

I don't see $token defined anywhere?

Member

kemo commented Apr 11, 2014

Targeted against the wrong branch + undefined variable $token used in ORM::factory('user_token', array('token' => $token))->loaded(). Closing

@kemo kemo closed this Apr 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment