Skip to content

Fixed errors with PHPDoc annotations for methods of Kohana_ORM class #72

Merged
merged 1 commit into from Apr 11, 2014

3 participants

@snovichkov

Fixed errors with PHPDoc annotations for methods of Kohana_ORM class for compatibility with standards and PHPStorm IDE

@kemo kemo merged commit 1a340cb into kohana:3.2/develop Apr 11, 2014
@WinterSilence

@return $this - not correctly return variable.

@return [Type] [<description>]
http://www.phpdoc.org/docs/latest/for-users/phpdoc/tags/return.html

@WinterSilence

__construct() always return void!

@kemo
Kohana PHP Framework member
kemo commented Apr 11, 2014

@WinterSilence true, just fixed that one

@WinterSilence

you fix not all, see #72 (comment)

@kemo
Kohana PHP Framework member
kemo commented Apr 11, 2014

I undid this PR completely, none of it looks right tbh. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.