Fixed errors with PHPDoc annotations for methods of Kohana_ORM class #72

Merged
merged 1 commit into from Apr 11, 2014

Conversation

Projects
None yet
3 participants
@snovichkov

Fixed errors with PHPDoc annotations for methods of Kohana_ORM class for compatibility with standards and PHPStorm IDE

kemo added a commit that referenced this pull request Apr 11, 2014

Merge pull request #72 from snovichkov/3.2/develop
Fixed errors with PHPDoc annotations for methods of Kohana_ORM class

@kemo kemo merged commit 1a340cb into kohana:3.2/develop Apr 11, 2014

@WinterSilence

This comment has been minimized.

Show comment
Hide comment
@WinterSilence

WinterSilence Apr 11, 2014

@return $this - not correctly return variable.

@return [Type] [<description>]
http://www.phpdoc.org/docs/latest/for-users/phpdoc/tags/return.html

@return $this - not correctly return variable.

@return [Type] [<description>]
http://www.phpdoc.org/docs/latest/for-users/phpdoc/tags/return.html

@WinterSilence

This comment has been minimized.

Show comment
Hide comment
@WinterSilence

WinterSilence Apr 11, 2014

__construct() always return void!

__construct() always return void!

@kemo

This comment has been minimized.

Show comment
Hide comment
@kemo

kemo Apr 11, 2014

Member

@WinterSilence true, just fixed that one

Member

kemo commented Apr 11, 2014

@WinterSilence true, just fixed that one

@WinterSilence

This comment has been minimized.

Show comment
Hide comment
@WinterSilence

WinterSilence Apr 11, 2014

you fix not all, see #72 (comment)

you fix not all, see #72 (comment)

@kemo

This comment has been minimized.

Show comment
Hide comment
@kemo

kemo Apr 11, 2014

Member

I undid this PR completely, none of it looks right tbh. Thanks for the heads up!

Member

kemo commented Apr 11, 2014

I undid this PR completely, none of it looks right tbh. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment