Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

More robust version checking of underlying phpUnit #25

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

chandeeland commented May 11, 2012

... the changes are not caught by the function_exists test, so i changed to to check PHPUnit's version function

@chandeeland chandeeland the test for PHPUnit version is more robust. I'm using PHPUnit 3.6, a…
…nd the changes are not caught by the function_exists test, so i changed to to check PHPUnit's version function
9771c95

Build Scheduled

@hkdobrev hkdobrev commented on the diff Feb 3, 2013

classes/kohana/unittest/tests.php
@@ -51,7 +51,8 @@ static public function configure_environment($do_whitelist = TRUE, $do_blacklist
spl_autoload_register(array('Unittest_tests', 'autoload'));
// As of PHPUnit v3.5 there are slight differences in the way files are black|whitelisted
- self::$phpunit_v35 = function_exists('phpunit_autoload');
+ list($major, $minor, $release) = explode('.', PHPUnit_Runner_Version::id());
Member

Zeelot commented Feb 25, 2013

This pull doesn't seem mergable any more but like @hkdobrev said, version_compare should be simpler. You also seem to be using && and || instead of AND and OR.

I would also like to simply get rid of any version comparisons from now on anyway since we include phpunit using composer so we only ever have to support the version we are requiring in composer.json.

@Zeelot Zeelot closed this Feb 25, 2013

I would also like to simply get rid of any version comparisons from now on anyway since we include phpunit using composer so we only ever have to support the version we are requiring in composer.json.

👍 on what @Zeelot said. This is one of the best sides of using Composer. Support only what you use and not everything available.

Contributor

zombor commented Feb 25, 2013

I'm pretty sure I got rid of all that. Maybe it was in the 3.3 branch.

Member

Zeelot commented Feb 25, 2013

You're right, all this sillyness is gone from 3.3 :) excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment