Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-48954] - Add the Jenkins-ClassFilter-Whitelisted manifest entry #408

Closed

Conversation

Projects
None yet
3 participants
@oleg-nenashev
Copy link
Collaborator

commented Jan 16, 2018

In Jenkins project JEP-200 introduces serious changes in class serialization since 2.102. Some Jenkins plugins (e.g. GitHub Pull Request Builder) are affected by the change due to serialization of GitHub API (see JENKINS-48950). It is still TBD whether such serialization is desirable, but I am putting this PR here just in case.

Please do not merge for now

@reviewbybees @jglick

@KostyaSha

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2018

Why do you need affect unrelated to jenkins libraries with jenkins related stuff?

@oleg-nenashev

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 16, 2018

@KostyaSha this PR is a proposal for discussion (we're working on other solutions like jenkinsci/github-api-plugin#18 or direct fixes in plugins).
If you have any theories how Jenkins-unrelated things are going to be affected by this change, please comment.

@KostyaSha

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2018

That a red light that you do something wrong in jenkins if you influence on libraries. Fix jenkins or whatever you do on jenkins side.

@KostyaSha
Copy link
Contributor

left a comment

smells like a jenkins missdesign

@oleg-nenashev

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 16, 2018

@KostyaSha to make you happy, so far it seems to be a GHPRB Plugin misdesign ;)

@KostyaSha

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2018

This is not a missdesign, if somebody wants something to deserialise - they should be able to do it. github-api is binary compatible so it safe to use classes.

@jglick
Copy link
Contributor

left a comment

Seems to be neither necessary (given the plugin fix) nor desirable.

@oleg-nenashev

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 25, 2018

No need in this change so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.