Skip to content
Permalink
Browse files

%BASE% was broken

I haven't pinned down which change caused this, but `%BASE%` was supposed to point to a directory and not the executable.
  • Loading branch information...
kohsuke committed Apr 3, 2015
1 parent 20cdd53 commit 2bf9e858a94c7caca41812d644543e61ba1c179e
Showing with 1 addition and 1 deletion.
  1. +1 −1 ServiceDescriptor.cs
@@ -67,7 +67,7 @@ public ServiceDescriptor()
dom.Load(BasePath + ".xml");

// register the base directory as environment variable so that future expansions can refer to this.
Environment.SetEnvironmentVariable("BASE", p);
Environment.SetEnvironmentVariable("BASE", d.FullName);
// ditto for ID
Environment.SetEnvironmentVariable("SERVICE_ID", Id);
Environment.SetEnvironmentVariable("WINSW_EXECUTABLE", ExecutablePath);

3 comments on commit 2bf9e85

@kohsuke

This comment has been minimized.

Copy link
Owner Author

replied Apr 3, 2015

Looks like 91ed4b3 is the responsible one, so at least the regression is fairly recent.

@oleg-nenashev

This comment has been minimized.

Copy link
Collaborator

replied Apr 3, 2015

Yes. The variable changed it's behavior and nobody noticed.
I've created #91 for the sake of consistency.

@oleg-nenashev

This comment has been minimized.

Copy link
Collaborator

replied Apr 15, 2015

I hope to release winsw-1.18 on this week. I'll update Jenkins dependencies to this version

Please sign in to comment.
You can’t perform that action at this time.