Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #142 - Deploy the automatic build on Appveyor #144

Merged
merged 17 commits into from Dec 4, 2016
Merged

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Dec 3, 2016

Finally I decided to try Appveyor before using VS Team Services.
The draft project is available here: https://ci.appveyor.com/project/oleg-nenashev/winsw

TODOs:

  • Appveyor should generate a temporary SNK file (temporary solution)
  • Build process should be passing
  • Appveyor should be launching and reporting tests from the DLL (NUnit 2?)
  • Artifacts should be published for each build (WinSW.exe and maybe configuration sample)

Edited by @NextTurn: Fixes #142

@oleg-nenashev oleg-nenashev modified the milestones: winsw-3, winsw-2.0 Dec 3, 2016
@oleg-nenashev
Copy link
Member Author

@reviewbybees just in case

@@ -2,7 +2,7 @@
export "PATH=$PATH:/cygdrive/c/Program Files/Windows Kits/8.1/bin/x86"
for f in Release Debug;
do
signtool sign /f winsw_cert.pfx /t http://timestamp.verisign.com/scripts/timestamp.dll bin/$f/winsw.exe
signtool sign /f winsw-key.snk /t http://timestamp.verisign.com/scripts/timestamp.dll bin/$f/winsw.exe
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sign script is not going to work well with the new project structure anyway. But it should not be required at all

@oleg-nenashev
Copy link
Member Author

Well, now I just need to fix the test failures. Which is good...

@ghost
Copy link

ghost commented Dec 3, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev oleg-nenashev self-assigned this Dec 4, 2016
@oleg-nenashev
Copy link
Member Author

@reviewbybees done.
Merging a a maintainer since it is not a code part && I want to unblock PR builder and test PRs. If there are any concerns, I will address them in follow-up patches

@oleg-nenashev oleg-nenashev merged commit 6c0f6d1 into master Dec 4, 2016
@oleg-nenashev oleg-nenashev deleted the appveyor branch December 4, 2016 08:34
@nxtn nxtn modified the milestones: winsw-2.0, 2.0.1, 2.0.0 Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy Pull request builder for WinSW
2 participants