Permalink
Browse files

Fix mismatch createConnection and Socket.connect

net.createConnection() is wrapper for net.Socket.connect(),
but There is mismatch between them.

net.createConnection(port, [host])
net.Socket.connect(port, [host], [callback])
  • Loading branch information...
koichik committed Jun 21, 2011
1 parent 02699a3 commit 2678be43904b54d6ead0f88c3471262e7061c631
Showing with 57 additions and 9 deletions.
  1. +6 −4 doc/api/net.markdown
  2. +2 −2 lib/net_legacy.js
  3. +7 −3 lib/net_uv.js
  4. +42 −0 test/simple/test-net-create-connection.js
View
@@ -26,15 +26,17 @@ the socket is established the `'connect'` event will be emitted.
The arguments for this method change the type of connection:
-* `net.createConnection(port, [host])`
+* `net.createConnection(port, [host], [callback])`
- Creates a TCP connection to `port` on `host`. If `host` is omitted, `localhost`
- will be assumed.
+ Creates a TCP connection to `port` on `host`. If `host` is omitted,
+ `localhost` will be assumed.
-* `net.createConnection(path)`
+* `net.createConnection(path, [callback])`
Creates unix socket connection to `path`
+The `callback` parameter will be added as an listener for the 'connect` event.
+
---
### net.Server
View
@@ -261,9 +261,9 @@ Socket.prototype.open = function(fd, type) {
};
-exports.createConnection = function(port, host) {
+exports.createConnection = function(port, host, callback) {
var s = new Socket();
- s.connect(port, host);
+ s.connect(port, host, callback);
return s;
};
View
@@ -24,9 +24,9 @@ exports.createServer = function() {
};
-exports.connect = exports.createConnection = function(port, host) {
+exports.connect = exports.createConnection = function(port, host /* [cb] */ ) {
var s = new Socket();
- s.connect(port, host);
+ s.connect(port, host, arguments[2]);
return s;
};
@@ -284,9 +284,13 @@ function afterWrite(status, handle, req, buffer) {
}
-Socket.prototype.connect = function(port, host) {
+Socket.prototype.connect = function(port, host /* [cb] */) {
var self = this;
+ if (typeof arguments[2] === 'function') {
+ self.on('connect', arguments[2]);
+ }
+
timers.active(this);
require('dns').lookup(host, function(err, ip, addressType) {
@@ -0,0 +1,42 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+var common = require('../common');
+var assert = require('assert');
+var net = require('net');
+
+var tcpPort = common.PORT;
+var connectHappened = false;
+
+var server = net.createServer(function(socket) {
+ server.close();
+ socket.end();
+});
+server.listen(tcpPort, 'localhost', function() {
+ var client = net.createConnection(tcpPort, 'localhost', function() {
+ connectHappened = true;
+ });
+});
+
+process.on('exit', function () {
+ assert.ok(connectHappened);
+});
+

0 comments on commit 2678be4

Please sign in to comment.