Skip to content


Subversion checkout URL

You can clone with
Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: koichik/node
head fork: koichik/node
Checking mergeability… Don't worry, you can still create the pull request.
Commits on Oct 12, 2012
@isaacs isaacs Now working on 0.8.13 58db21e
@maxogden maxogden doc: set default background color to white 323bbdb
@TooTallNate TooTallNate repl: ensure each REPL instance gets its own "context"
Before there was this weird module-scoped "context" variable which seemingly
shared the "context" of subsequent REPL instances, unless ".clear" was invoked
inside the REPL. To be proper, we need to ensure that each REPL gets its own
"context" object. I literally don't know why this "sharing" behavior was in place
before, but it was just plain wrong.
Commits on Oct 13, 2012
@bnoordhuis bnoordhuis doc: rectify http.ClientResponse close/end events
* The 'close' event doesn't emit an error object.

* It's possible for a 'close' event to come after an 'end' event, contrary to
  what the documentation said.

Fixes #4116.
Commits on Oct 14, 2012
@janl janl docs: fix copy and paste error a7b5938
Commits on Oct 15, 2012
@bnoordhuis bnoordhuis Revert "Disable OpenSSL UI"
This reverts commit 1c88c3b.

It breaks the "read a password from stdin" functionality that OpenSSL provides.

Fixes #4059, #4143.


@bnoordhuis bnoordhuis configure: turn on VFPv3 on ARMv7
Fixes a V8 build error caused by missing arm_fpu and arm_neon settings.

This is a back-port of commit bbf6b4e from the master branch.

Fixes #4142.
@TooTallNate TooTallNate test: disable global variable check for "test-repl-options.js"
Previously, the "global" mode of REPLs was broken when created after another
non-global REPL (they would end up sharing the same context). Now that "global"
mode is fixed for that case (b1e78ce), this
test case gets its global scope modified with "module" and other REPL-specific
properties, so disable the global check.
Commits on Oct 16, 2012
@isaacs isaacs doc: Typo. s/arguemnt/argument/ 627f0d2
Commits on Oct 21, 2012
@bnoordhuis bnoordhuis test: add diffie-hellman regression test
Exercises the error path in DiffieHellman::ComputeSecret() in src/
@bnoordhuis bnoordhuis crypto: fix DH 1 byte buffer underflow
Passing a bad key to DiffieHellman::ComputeSecret() made it zero the byte
before the heap allocated buffer due to an erroneous size calculation.
@bnoordhuis bnoordhuis crypto: fix DH use-after-free and memory leak
Fix a use-after-free bug and a memory leak in the error path of

* the BIGNUM key was used after being freed with BN_free().
* the output buffer was not freed
Commits on Oct 23, 2012
@yangguo-chromium-org yangguo-chromium-org v8: use correct timezone information on Solaris
`timezone` variable contains the difference, in seconds, between UTC and
local standard time (see `man 3 localtime` on Solaris).

Call to `tzset` is required to apply contents of `TZ` variable to
`timezone` variable.


Review URL:
Patch from Maciej Małecki <>.

This is a back-port of upstream commit r12802.
@jacobsa jacobsa typed arrays: use `signed char` for signed int8s
The C standard allows plain `char` to be unsigned. The build environment
at Google trips this issue.
@bnoordhuis bnoordhuis test: add typed arrays regression test
Ensure that uint8 values >= 128 are correctly promoted to int8 <= -1.
@isaacs isaacs npm: Upgrade to 1.1.64 7413df0
@isaacs isaacs V8: Upgrade to 29d12c7
@isaacs isaacs V8: Reapply patches 76a6c4b
@olalonde olalonde doc: child_process: document uid and gid spawn() options 626db18
Commits on Oct 24, 2012
@piscisaureus piscisaureus repl: call resume() after setRawMode()
Solves #4178, but does not fix the underlying issue
@isaacs isaacs blog: Post for v0.9.3 release 82a72e9
@bnoordhuis bnoordhuis url: parse hostnames that start with - or _
Allow hostnames like '' and ''.

Fixes #4177.
@bnoordhuis bnoordhuis build: add --unsafe-optimizations configure switch
Turns on -O3 and other optimizations that may produce buggy code with some
toolchains. Use at your own risk.
@bnoordhuis bnoordhuis v8: remove optimization switches
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi, we set
them globally in $(TOPLEVEL)/common.gypi.

Commit 29d12c7 accidentally reintroduced the switches again. In particular,
the 'cflags!': ['-O2','-Os'] section forced building V8 without any
optimizations, resulting in a steep (~66%) performance drop on some benchmarks.

Fixes #4191.
Commits on Oct 25, 2012
@isaacs isaacs events: Make the EventEmitter class monomorphic
Always add domain, _events, and _maxListeners properties, set to the
default values at first.

Leads to a very very slight perf improvement when using setMaxListeners,
or dealing with a lot of EE objects that don't have any listeners.
@isaacs isaacs npm: Upgrade to 1.1.65 822e13d
@isaacs isaacs V8 build: 'echo -n' considered harmful e1bdde0
@isaacs isaacs 2012.10.25, Version 0.8.13 (Stable)
* V8: Upgrade to

* npm: Upgrade to 1.1.65

* url: parse hostnames that start with - or _ (Ben Noordhuis)

* repl: Fix Windows 8 terminal issue (Bert Belder)

* typed arrays: use signed char for signed int8s (Aaron Jacobs)

* crypto: fix bugs in DiffieHellman (Ben Noordhuis)

* configure: turn on VFPv3 on ARMv7 (Ben Noordhuis)

* Re-enable OpenSSL UI for entering passphrases via tty (Ben Noordhuis)

* repl: ensure each REPL instance gets its own "context" (Nathan Rajlich)
@isaacs isaacs Merge branch 'v0.8.13-release' into v0.8 d269f7e
@isaacs isaacs Now working on 0.8.14 648e387
@isaacs isaacs blog: Post for v0.8.13 d130bb0
@isaacs isaacs events: Don't clobber pre-existing _events obj in EE ctor 45a13d9
@isaacs isaacs 2012.10.25, Version 0.8.14 (Stable)
* events: Don't clobber pre-existing _events obj in EE ctor (isaacs)
@isaacs isaacs Merge branch 'v0.8.14-release' into v0.8 4379e49
@isaacs isaacs Now working on 0.8.15 54e88b3
@isaacs isaacs blog: Post for v0.8.14 7fe1671
@isaacs isaacs blog: Correct shasums for v0.8.14 5f0a10a
Commits on Oct 29, 2012
@fmarier fmarier doc: reflect hostname v. host preference in examples
The documentation for http.request and https.request states that
`hostname` is preferred over `host` so the code examples should
use that option name.
Commits on Oct 30, 2012
@fmarier fmarier doc: remove duplicate set of options 44dd2c3
Commits on Nov 08, 2012
@piscisaureus piscisaureus windows: fix the x64 debug build 9b22944
@piscisaureus piscisaureus domains: don't crash if domain is set to null
Closes #4256
Commits on Nov 20, 2012
@bnoordhuis bnoordhuis deps: upgrade libuv to 5639b2f 7716828
Commits on Nov 22, 2012
@trevnorris trevnorris doc: Add lines about additonal uses of Buffer
That Buffers can be used with Typed Array Views and DataViews. Included
are a couple simple examples.

Closes #4257.
Commits on Nov 23, 2012
@isaacs isaacs npm: Upgrade to 1.1.66 db008f7
@isaacs isaacs blog: Don't filter out non-latest release notes
This causes too many people to ask me why it's broken.
Commits on Nov 24, 2012
@bnoordhuis bnoordhuis net: fix net.connect() resource leak
The 'connect' event listener was attached with .on(), which blocked it from
getting garbage collected. Use .once() instead.

Fixes #4308.
Commits on Nov 26, 2012
@bnoordhuis bnoordhuis tls: fix tls.connect() resource leak
The 'secureConnect' event listener was attached with .on(), which blocked it
from getting garbage collected. Use .once() instead.

Fixes #4308.
@isaacs isaacs 2012.11.26, Version 0.8.15 (Stable)
* npm: Upgrade to 1.1.66 (isaacs)

* linux: use /proc/cpuinfo for CPU frequency (Ben Noordhuis)

* windows: map WSAESHUTDOWN to UV_EPIPE (Ben Noordhuis)

* windows: map ERROR_GEN_FAILURE to UV_EIO (Bert Belder)

* unix: do not set environ unless one is provided (Charlie McConnell)

* domains: don't crash if domain is set to null (Bert Belder)

* windows: fix the x64 debug build (Bert Belder)

* net, tls: fix connect() resource leak (Ben Noordhuis)
@isaacs isaacs Merge branch 'v0.8.15-release' into v0.8 9f51fd6