Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album link i Lightbox uses internal id instead of album name #33

Open
BlackSkorpio opened this issue Aug 29, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@BlackSkorpio
Copy link

commented Aug 29, 2016

As the title suggests, if you click on the album name in lightbox you are taken back to the album, but instead of using the real slug (album name) it is instead something like
http://domain.com/albums/740784e55171ba6be856c246cf6efead/

Where as the 740784e55171ba6be856c246cf6efead corresponds to the album name/slug spring

Example on this can be seen if you open up any images here in lightbox and hover over the album name "Våren"

@BlackSkorpio

This comment has been minimized.

Copy link
Author

commented Mar 7, 2017

A interesting thing is that the DEV install (kokenDEV) the lightbox album name is linking back as it should!
Two installs on the same server, with pretty much the same setup behaving differently!

@BlackSkorpio

This comment has been minimized.

Copy link
Author

commented Apr 17, 2017

As it seams whit further testing this is related to <koken:parent>

When using it as:

<koken:parent>
	<koken:link>...</koken:link>
<koken:else>
	Something else
</koken:parent>

The above code is directly from the lightbox, but also used here:
https://bay3r.de/alben/12-kreuze/blog/zwoelf-kreuze/
(Hover the 12 Kreuze)

As you can see the <koken:link> here produces the link:
https://bay3r.de/alben/d3908540ae369b06df6d266f26d198bd/
Instead of the correct:
https://bay3r.de/alben/12-kreuze/

@BlackSkorpio

This comment has been minimized.

Copy link
Author

commented Apr 17, 2017

Closed by mistake

@BlackSkorpio BlackSkorpio reopened this Apr 17, 2017

@BlackSkorpio

This comment has been minimized.

Copy link
Author

commented Apr 17, 2017

Looking over the whole code in both the OxyGen 3 supplied next/previous nav bar and the core lightbox.lens it seams the easy fix is to add to="album" filter:id="{{ album.id }}" to the <koken:link> in the <koken:parent>

So the above is fixed with:

<koken:parent>
	<koken:link to="album" filter:id="{{ album.id }}">...</koken:link>
<koken:else>
	Something else
</koken:parent>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.