Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in the different RSS feeds is having relative paths #55

Closed
BlackSkorpio opened this issue May 26, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@BlackSkorpio
Copy link

commented May 26, 2017

Snippet from my timeline.rss

<?xml version="1.0" encoding="utf-8"?>
<rss version="2.0" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:atom="http://www.w3.org/2005/Atom" xmlns:georss="http://www.georss.org/georss" xmlns:media="http://search.yahoo.com/mrss/" xmlns:dc="http://purl.org/dc/elements/1.1/">
	<channel>
	<title><![CDATA[Baldurs Photography: Tidslinje]]></title>
	<link><![CDATA[https://varoystrand.se/tidslinje/]]></link>
	<description><![CDATA[Senaste aktiviteten från Baldurs Photography]]></description>
	<generator>http://koken.me</generator>
	<lastBuildDate>Fri, 26 May 2017 14:50:41 +0200</lastBuildDate>
	<atom:link href="https://varoystrand.se/feed/timeline/recent.rss" rel="self" type="application/rss+xml" />	<item>
	<title><![CDATA[Vintern (1 ny item)]]></title>
	<link><![CDATA[https://varoystrand.se/album/winter/]]></link>
	<guid><![CDATA[https://varoystrand.se/album/winter/]]></guid>
	<pubDate>Thu, 19 Jan 2017 16:44:15 +0100</pubDate>
	<description><![CDATA[Lite bilder för att påminna oss om att även vintern döljer en härlighet och många vackra ting]]></description>
	<content:encoded><![CDATA[<figure><img alt="Heavens on fire" src="/storage/cache/images/000/669/170119-DSC5260,medium_large.1485355206.jpg" width="800"><figcaption>Heavens on fire</figcaption></figure>]]></content:encoded>
	<media:license url=""><![CDATA[]]></media:license>
	<media:title><![CDATA[Vintern (1 ny item)]]></media:title>
	<media:content url="/storage/cache/images/000/669/170119-DSC5260,medium_large.1485355206.jpg" width="800" type="image/jpeg" />
	<media:thumbnail url="/storage/cache/images/000/669/170119-DSC5260,small.1485355206.jpg" width="100" />	<media:credit role="photographer"><![CDATA[Bjarne Varöystrand]]></media:credit>
	<dc:creator><![CDATA[Bjarne Varöystrand]]></dc:creator>
	</item>
.....................................................................
	</channel>
</rss>

Issue was first reported here: https://kokensupport.com/viewtopic.php?t=635

Tested on Koken 22.21 and 22.22.beta.x

@MikeCostello

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2017

Rolled back the relative URL changes from v0.22.21. Added relative attribute to koken:img, that is true by default. Available for testing in v0.22.22-beta.2

@BlackSkorpio

This comment has been minimized.

Copy link
Author

commented Jun 1, 2017

Missed beta.2 ;)
But beta.3 looks good, nothing unexpected; so far.

Could this relative attribute be extended to also cover <koken:background></koken:background> and <koken:pulse /> ?

@MikeCostello

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

koken/koken@24942ec added relative to koken:background & koken:pulse in 0.22.22-beta.4

@BlackSkorpio

This comment has been minimized.

Copy link
Author

commented Jun 2, 2017

From what I can judge, koken:background and koken:imgis fine, but koken:pulse is not listening to the relative attribute in beta.4

Same result on all three test sites, tested with the default slideshows in Elementary and OxyGen, pulse is still using absolute paths

@BlackSkorpio

This comment has been minimized.

Copy link
Author

commented Jun 4, 2017

Fixed in beta.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.