Issue related to Session, Auth, and Captcha #5

Closed
raeldc opened this Issue Jun 12, 2010 · 2 comments

Projects

None yet

3 participants

@raeldc
raeldc commented Jun 12, 2010

To explain this issue, please read this first:

http://dev.kohanaframework.org/issues/2957

As I explained in the issue above, when the Session is instantiated before Captcha, the 'captcha_response' value will not be written in the session because Session::write was called first in the queue of register_shutdown_function. Auth will more like cause this issue to arise because it uses the Session, and it's very likely that Auth is called before Captcha.

If in case my suggested fix is rejected (which is very likely), I'm wondering if you can fix this issue by not calling register_shutdown_function but instead, call the Captcha::update_response_session() somewhere else where it doesn't need to be called on shutdown.

Thanks!

I don't know if I considered all the scenarios already, but there should be a solution somewhere.

@alright
alright commented Jun 30, 2010

I have the same issue with module.

http://forum.kohanaframework.org/comments.php?DiscussionID=3578

The solution I found on Kohana Forum is to place update_response_session() in the Controller and deactivate register_shutdown_function():

public function after()
{
    Captcha::update_response_session();
}
@kolanos
Owner
kolanos commented Sep 7, 2010

I will implementing this suggestion in the next commit, thanks!

Shutdown register is not the ideal obviously, but since the event handling functionality was removed from Kohana the options were limited.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment