Make createCsvFileWriter()'s <options> param optional #15

Merged
merged 1 commit into from Feb 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

runningskull commented Feb 26, 2012

Hey Pavel,

First off, thanks for ya-csv. It's a great library and saved me hours of work. I appreciate it!

This patch is to fix a "quirk" in the new version that makes the options param to createCsvFileWriter() required, when it seems it's meant to be optional.

It's not broken as-is, but you do have to pass in {flags: 'w'} for the options parameter or else it'll throw an error.

Let me know if that wasn't the intent.

Thanks!

@koles koles added a commit that referenced this pull request Feb 26, 2012

@koles koles Merge pull request #15 from runningskull/master
Make createCsvFileWriter()'s <options> param optional
4c14735

@koles koles merged commit 4c14735 into koles:master Feb 26, 2012

Owner

koles commented Feb 26, 2012

Thanks a lot for a quick fix! Version 0.9.1 published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment