Correctly emit errors thrown when we attempt to parse a line. #33

Merged
merged 1 commit into from Sep 10, 2014

4 participants

@alexjeffburke

We hit an issue using 0.9.2 with an error being thrown while parsing a line rather than being emitted as an event from the stream.

This change is intended to catch any parse errors and emit them as an error event - as written it maintains the invariant that once an error has been emitted no more data is processed.

@wmbutler

I'd like to upvote this request. If an error is thrown, it would be great to be able to skip that line and continue parsing.

@davidpadbury

Would be nice to get this incorporated.

@koles koles merged commit b9d7044 into koles:master Sep 10, 2014
@koles
Owner

Fixed in 0.9.4. Big thanks to Alex and my apologies for a delayed response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment