remove base mixers from _roboDrops pref #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #757 +/- ##
=========================================
Coverage 23.61% 23.61%
Complexity 10551 10551
=========================================
Files 1014 1014
Lines 158215 158215
Branches 34989 34989
=========================================
+ Hits 37357 37360 +3
+ Misses 114059 114057 -2
+ Partials 6799 6798 -1
Continue to review full report at Codecov.
|
midgleyc
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to spade the decay rate, we noticed the data didn't make any sense. It was confirmed by a dev (cannonfire40) that the base mixers operate on a completely separate roll, and should not count as a drop for the purposes of this. I have removed those familiar messages accordingly.