Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Object[][] from BarrelPrayerCommand #827

Merged
merged 2 commits into from Jun 20, 2022

Conversation

midgleyc
Copy link
Member

Add tests.

@midgleyc midgleyc requested a review from a team as a code owner June 20, 2022 18:56
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #827 (47fb329) into main (6b54897) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #827      +/-   ##
============================================
+ Coverage     25.37%   25.41%   +0.03%     
- Complexity    11576    11606      +30     
============================================
  Files          1019     1019              
  Lines        159516   159511       -5     
  Branches      35150    35149       -1     
============================================
+ Hits          40484    40544      +60     
+ Misses       111407   111331      -76     
- Partials       7625     7636      +11     
Impacted Files Coverage Δ
...e/kolmafia/textui/command/BarrelPrayerCommand.java 82.92% <80.00%> (+65.53%) ⬆️
src/net/sourceforge/kolmafia/KoLCharacter.java 48.76% <0.00%> (+0.12%) ⬆️
...sourceforge/kolmafia/session/ChoiceAdventures.java 31.09% <0.00%> (+0.13%) ⬆️
...et/sourceforge/kolmafia/objectpool/Concoction.java 58.94% <0.00%> (+0.18%) ⬆️
...forge/kolmafia/persistence/ConcoctionDatabase.java 45.27% <0.00%> (+0.23%) ⬆️
...et/sourceforge/kolmafia/session/ChoiceManager.java 12.50% <0.00%> (+0.30%) ⬆️
src/net/sourceforge/kolmafia/RequestLogger.java 15.78% <0.00%> (+0.31%) ⬆️
...ge/kolmafia/swingui/panel/UseItemEnqueuePanel.java 36.36% <0.00%> (+0.74%) ⬆️
...net/sourceforge/kolmafia/request/KnollRequest.java 18.18% <0.00%> (+2.27%) ⬆️
...et/sourceforge/kolmafia/request/ShrineRequest.java 17.44% <0.00%> (+8.13%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b54897...47fb329. Read the comment docs.

@midgleyc midgleyc enabled auto-merge (squash) June 20, 2022 20:51
@midgleyc midgleyc merged commit 63d9038 into kolmafia:main Jun 20, 2022
@midgleyc midgleyc deleted the barrel-prayer-command branch June 20, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants