New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The `Binary Double` instance does not roundtrip. #158

Open
NorfairKing opened this Issue Nov 6, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@NorfairKing
Copy link

NorfairKing commented Nov 6, 2018

  1) Test.Validity.Binary, Binary Double (unchecked), decode :: Double -> Data.ByteString.Lazy.ByteString, ensures that encode and decode are inverses for "unchecked Double"'s
       Falsifiable (after 8 tests):
         NaN
       expected: NaN
        but got: -Infinity
@QuRyu

This comment has been minimized.

Copy link

QuRyu commented Jan 8, 2019

See the discussion on #69 and #64. The problem is basically that encode uses decodeFlat, which does not handle NaN case properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment