Skip to content

feat: Add tests for case insensitivity and whitespace handling in recommendations(#473)#503

Open
vansh-09 wants to merge 1 commit into
komalharshita:mainfrom
vansh-09:main
Open

feat: Add tests for case insensitivity and whitespace handling in recommendations(#473)#503
vansh-09 wants to merge 1 commit into
komalharshita:mainfrom
vansh-09:main

Conversation

@vansh-09
Copy link
Copy Markdown

Summary [required]

Adds regression tests to ensure skill matching is case-insensitive and that leading/trailing
whitespace is ignored.
No changes to the recommendation algorithm were required — the fix is test coverage and
documentation.

Related Issue [required]

Closes #473

Type of Change [required]

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
tests/test_basic.py Added regression tests for case-insensitive and whitespace-stripping skill matching

How to Test This PR [required]

  1. Clone this branch: git checkout your-branch-name
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000 and...
  5. Run the tests: python tests/test_basic.py or python -m pytest -q

Expected test output: all tests pass with zero failures.

Test Results [required]

/DevPath/.venv/bin/python -m pytest -q
................................                                         [100%]
32 passed in 0.28s

Self-Review Checklist [required]

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py (or pytest) and all tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

None

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

@vansh-09 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: skill matching is case-sensitive — "python" and "Python" treated as different skills

1 participant