Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test case for view_renderer leaking to rails (#144) #146

Merged
merged 5 commits into from Sep 18, 2019

Conversation

@robink
Copy link
Contributor

commented Aug 28, 2019

Added some test cases (and a failing one) according to #144

@coveralls

This comment has been minimized.

Copy link

commented Aug 28, 2019

Pull Request Test Coverage Report for Build 933

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 99.454%

Totals Coverage Status
Change from base Build 814: 0.006%
Covered Lines: 182
Relevant Lines: 183

💛 - Coveralls
Spone and others added 2 commits Sep 11, 2019
@Spone

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

Thanks @robink! We still have this issue on ruby-head which is unrelated to your changes, we'll have a look soon!

Spone added 2 commits Sep 18, 2019
@Spone
Spone approved these changes Sep 18, 2019
@Spone

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2019

Thanks @robink for your work on this!

@Spone Spone merged commit eb4267b into komposable:master Sep 18, 2019
9 checks passed
9 checks passed
Ruby 2.5.x, Rails 5.0.x
Details
Ruby 2.5.x, Rails 5.1.x
Details
Ruby 2.5.x, Rails 5.2.x
Details
Ruby 2.5.x, Rails 6.0.x
Details
Ruby 2.6.x, Rails 5.0.x
Details
Ruby 2.6.x, Rails 5.1.x
Details
Ruby 2.6.x, Rails 5.2.x
Details
Ruby 2.6.x, Rails 6.0.x
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.