Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that +all+ returns namespaced components #160

Merged

Conversation

@apauly
Copy link
Contributor

apauly commented Dec 13, 2019

Fix that Komponent::Component.all actually returns all components, including namespaced components.

Close #125

@Spone

This comment has been minimized.

Copy link
Collaborator

Spone commented Dec 13, 2019

Great! Thanks @apauly for the contribution! I guess it fixes #125 right?

@Spone Spone requested review from nicolas-brousse and Spone Dec 13, 2019
@Spone Spone added the enhancement label Dec 13, 2019
@Spone
Spone approved these changes Dec 13, 2019
@apauly

This comment has been minimized.

Copy link
Contributor Author

apauly commented Dec 13, 2019

Might be, but I'm not sure as I haven't worked with the styleguide yet.

@apauly

This comment has been minimized.

Copy link
Contributor Author

apauly commented Jan 2, 2020

Hey @nicolas-brousse ,
did you find some time already to review this? If there's anything missing please let me know.

@nicolas-brousse

This comment has been minimized.

Copy link
Member

nicolas-brousse commented Jan 10, 2020

Hi @apauly! Sorry I was off the week before. I'll try to found some times in the following days.

@0xStarcat

This comment has been minimized.

Copy link

0xStarcat commented Jan 13, 2020

this would be amazing!

@nicolas-brousse

This comment has been minimized.

Copy link
Member

nicolas-brousse commented Jan 20, 2020

@apauly Good news, I'm looking into it. Sorry for the time I took.

I'm doing some more tests locally to check some other cases.

@nicolas-brousse

This comment has been minimized.

Copy link
Member

nicolas-brousse commented Jan 20, 2020

LGTM.

Before we go to merge this PR. Did you authorized maintainers to update your PR?

I did some other tests locally and I would like to push them. Otherwise I'll do it later.

I added two new components two have other path examples in the future.

@nicolas-brousse nicolas-brousse force-pushed the apauly:feature/fix-component-lookup branch from 8ca2a9e to 78e4a58 Jan 20, 2020
apauly and others added 2 commits Dec 13, 2019
@nicolas-brousse nicolas-brousse force-pushed the apauly:feature/fix-component-lookup branch from 78e4a58 to 61644a8 Jan 20, 2020
@nicolas-brousse

This comment has been minimized.

Copy link
Member

nicolas-brousse commented Jan 20, 2020

Thanks for your work @apauly

@nicolas-brousse nicolas-brousse merged commit d1ae3df into komposable:master Jan 20, 2020
9 checks passed
9 checks passed
Ruby 2.5.x, Rails 5.0.x
Details
Ruby 2.6.x, Rails 5.0.x
Details
Ruby 2.5.x, Rails 5.1.x
Details
Ruby 2.6.x, Rails 5.1.x
Details
Ruby 2.5.x, Rails 5.2.x
Details
Ruby 2.6.x, Rails 5.2.x
Details
Ruby 2.5.x, Rails 6.0.x
Details
Ruby 2.6.x, Rails 6.0.x
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.