Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow certificate_key to be specified like account_key #93
I added an option to the
While I'm all for generating new keys upon each renewal as it dramatically lowers the time window in which a leaked key can be abused, there are situations when a pre-existing key must be used.
For example if HPKP is already set up and clients expects private keys to be selected from a limited pool already advertised in the header, there's no other option but to generate a certificate that matches at least one of the entries already known by User-Agents.
@@ Coverage Diff @@ ## master #93 +/- ## ========================================= - Coverage 93.39% 93.2% -0.19% ========================================= Files 6 6 Lines 469 471 +2 ========================================= + Hits 438 439 +1 - Misses 31 32 +1
OK, I added that in c34a91b. CircleCI seems to fail on that, but I cannot comprehend its error message. It seems like some kind of internal error during the flake8 test, however flake8 reports no problems on my machine. (And the CircleCI output only contains stack traces showing that it couldn't run flake8...)