New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add join parameter #135

Merged
merged 1 commit into from Feb 18, 2017

Conversation

Projects
None yet
4 participants
@pinetree408
Copy link
Contributor

pinetree408 commented Feb 15, 2017

This pull request is about issue #75 .
Developed parts are as follows.

  • Development target
    • konlpy/tag/_hannanum
      • Add join parameter at parse function (default : False)
      • Add join parameter at pos function (default: False)
    • konlpy/tag/_kkma
      • Add join parameter at pos function (default: False)
    • konlpy/tag/_komoran
      • Add join parameter at parse function (default : False)
        • Add join parameter at _parse function (default : False)
      • Add join parameter at pos function (default: False)
    • konlpy/tag/_mecab
      • Add join parameter at parse function (default : False)
        • Add join parameter at split function (default : False)
      • Add join parameter at pos function (default: False)
    • konlpy/tag/_twitter
      • Add join parameter at pos function (default: False)
  • Test target
    • Cover pos functions of all the development targets.
  • Documentation
    • Add join parameter description at pos functinos of all the development targets.

@e9t Thanks!

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 15, 2017

Coverage Status

Coverage decreased (-0.3%) to 56.429% when pulling 1abd256 on pinetree408:enhancement/add-join-parameter into c553f8f on konlpy:master.

@e9t e9t merged commit d0fd8e8 into konlpy:master Feb 18, 2017

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.3%) to 56.429%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@e9t

This comment has been minimized.

Copy link
Member

e9t commented Feb 18, 2017

This is awesome! Will be included in the next release. Thanks 👍

@e9t e9t referenced this pull request Feb 18, 2017

Closed

Add `join` parameter #75

@suzinyou

This comment has been minimized.

Copy link

suzinyou commented Mar 22, 2017

So the join parameter already appears on the official doc (http://konlpy.org/ko/latest/api/konlpy.tag/), but as far as I know the newest release doesn't include this yet? Let me know if I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment