Add Python 3 compatibility. #17

Merged
merged 2 commits into from Sep 6, 2014

Projects

None yet

4 participants

@hyeshik
Contributor
hyeshik commented Sep 5, 2014

This patch allows most part of konlpy (except MeCab) to run on Python 3. All other tests in the test suite were passed on both 2.7 and 3.4. Thank you for the great project!

@hyeshik hyeshik Add support for Python 3.3+. Note that the wrappers for MeCab is not …
…working yet due to the lack of the Python 3 compatability in the underlying MeCab-python wrapper.
a22af7f
@coveralls

Coverage Status

Coverage decreased (-0.4%) when pulling a22af7f on hyeshik:master into 9670896 on e9t:master.

@combacsa
Contributor
combacsa commented Sep 5, 2014

how about modify "sys.version_info.major < 3" to "sys.version_info[0] < 3", to support python 2.6?

@hyeshik
Contributor
hyeshik commented Sep 6, 2014

@combacsa Thank you for the comment! I updated the changes.

@coveralls

Coverage Status

Coverage decreased (-0.4%) when pulling 27e9aae on hyeshik:master into 9670896 on e9t:master.

@e9t e9t merged commit 914e550 into konlpy:master Sep 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@e9t
Member
e9t commented Sep 6, 2014

This is wonderful! Thank you all for the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment