New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3 compatibility. #17

Merged
merged 2 commits into from Sep 6, 2014

Conversation

Projects
None yet
4 participants
@hyeshik
Copy link
Contributor

hyeshik commented Sep 5, 2014

This patch allows most part of konlpy (except MeCab) to run on Python 3. All other tests in the test suite were passed on both 2.7 and 3.4. Thank you for the great project!

Add support for Python 3.3+. Note that the wrappers for MeCab is not …
…working yet due to the lack of the Python 3 compatability in the underlying MeCab-python wrapper.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 5, 2014

Coverage Status

Coverage decreased (-0.4%) when pulling a22af7f on hyeshik:master into 9670896 on e9t:master.

@combacsa

This comment has been minimized.

Copy link
Contributor

combacsa commented Sep 5, 2014

how about modify "sys.version_info.major < 3" to "sys.version_info[0] < 3", to support python 2.6?

Use sys.version_info[0] instead of sys.version_info.major for Python …
…2.6 compatibility (suggested by combacsa).
@hyeshik

This comment has been minimized.

Copy link
Contributor

hyeshik commented Sep 6, 2014

@combacsa Thank you for the comment! I updated the changes.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 6, 2014

Coverage Status

Coverage decreased (-0.4%) when pulling 27e9aae on hyeshik:master into 9670896 on e9t:master.

e9t added a commit that referenced this pull request Sep 6, 2014

Merge pull request #17 from hyeshik/master
Add Python 3 compatibility.

@e9t e9t merged commit 914e550 into konlpy:master Sep 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@e9t

This comment has been minimized.

Copy link
Member

e9t commented Sep 6, 2014

This is wonderful! Thank you all for the great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment