New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPype dependency except Windows #94

Merged
merged 7 commits into from Nov 14, 2016

Conversation

Projects
None yet
3 participants
@shaynekang
Copy link
Contributor

shaynekang commented May 5, 2016

최근 konlpy를 빈번하게 설치할 일이 있었는데, 설치할때마다 JPype에러가 뜨더군요.

wowinsights@DeepDori:~/Documents/opensource/konlpy$ python setup.py install
Traceback (most recent call last):
  File "setup.py", line 7, in <module>
    from konlpy import __version__
  File "/home/wowinsights/Documents/opensource/konlpy/konlpy/__init__.py", line 15, in <module>
    from . import tag
  File "/home/wowinsights/Documents/opensource/konlpy/konlpy/tag/__init__.py", line 4, in <module>
    from ._hannanum import Hannanum
  File "/home/wowinsights/Documents/opensource/konlpy/konlpy/tag/_hannanum.py", line 7, in <module>
    import jpype
ImportError: No module named jpype

찾아보니 konlpy를 사용하기 위해서는 JPype가 필요하지만, 윈도우 환경에서는 JPype 패키징이 잘 구현되어있지 않아 패키지 의존성을 안 걸어둔 것으로 보입니다. (see installation)

저는 맥+리눅스 사용자라... 매 번 jpype를 설치하려니 불편하더군요. 그래서 패키지 의존성을 걸되, 예외적으로 윈도우에서는 걸지 않는 것으로 수정했습니다.

이제 리눅스와 맥에서는 pip install JPype1pip3 install JPype1-py3를 실행하지 않아도 konlpy가 잘 설치될 것입니다.

다음의 환경에서 테스트하였습니다.

  • MacOS(10.10.5): Python 2.6.9, Python 2.7.11, Python 3.5.1
  • Linux(Ubuntu 14.04): Python 2.6.9, Python 2.7.11, Python 3.5.1
  • Windows 10: Python 2.6.9, Python 2.7.11, Python 3.5.1
@coveralls

This comment has been minimized.

Copy link

coveralls commented May 5, 2016

Coverage Status

Coverage remained the same at 56.985% when pulling 952458d on shaynekang:jpype-dependency into 8e91592 on konlpy:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 5, 2016

Coverage Status

Coverage remained the same at 56.985% when pulling 871f361 on shaynekang:jpype-dependency into 8e91592 on konlpy:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 5, 2016

Coverage Status

Coverage remained the same at 56.985% when pulling e573cb8 on shaynekang:jpype-dependency into 8e91592 on konlpy:master.

@e9t e9t merged commit e573cb8 into konlpy:master Nov 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 56.985%
Details
@e9t

This comment has been minimized.

Copy link
Member

e9t commented Nov 14, 2016

기여 감사합니다! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment