Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support for konsta UI #133

Merged
merged 16 commits into from
Apr 12, 2023
Merged

RTL support for konsta UI #133

merged 16 commits into from
Apr 12, 2023

Conversation

ibilux
Copy link
Contributor

@ibilux ibilux commented Mar 28, 2023

Add support for multi-directional layouts for Konsta UI with tailwind rtl and ltr modifiers.
Trying to fix this issue #104.
A complete example can be found here:
https://github.com/ibilux/konsta-svelte-rtl

This PR is tested with the components showing the pictures below:

LTR RTL
LTR RTL

@ibilux
Copy link
Contributor Author

ibilux commented Mar 28, 2023

@ibilux
Copy link
Contributor Author

ibilux commented Apr 1, 2023

@nolimits4web tailwind has marked rtl and ltr variants as stable in v3.3.0.

@vltansky
Copy link
Collaborator

vltansky commented Apr 1, 2023

@ibilux why not to use logical properties instead of rtl/ltr?

easier to maintain and solid browser support.

https://tailwindcss.com/blog/tailwindcss-v3-3#simplified-rtl-support-with-logical-properties

@ibilux
Copy link
Contributor Author

ibilux commented Apr 1, 2023

@vltansky Yes, you are right. And I started testing them yesterday.
But as you can see the link you shared is posted in Tuesday, March 28, 2023, and it's before I started this PR.

@ibilux
Copy link
Contributor Author

ibilux commented Apr 2, 2023

@nolimits4web I have changed the code to use logical properties for inline direction instead of modifiers.
Everything seems to be working.
Please re-check the plugin-safe-areas.js file, cause I'm not sure if I did it right.

@nolimits4web
Copy link
Member

Thanks @ibilux, will check it on a days!

@nolimits4web nolimits4web merged commit 870258a into konstaui:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants