Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt local media #951

Open
keshto opened this issue Feb 12, 2017 · 3 comments

Comments

@keshto
Copy link

commented Feb 12, 2017

I thought I saw this but search and can't find it, maybe it was a different project. Pictures and other media (audio messages etc) should be locally encrypted and not accessible outside of kontalk (think signal). would require on the fly media description most likely.

related to #57

@daniele-athome daniele-athome changed the title encrypt media Encrypt media Feb 13, 2017

@daniele-athome daniele-athome changed the title Encrypt media Encrypt local media Feb 13, 2017

@daniele-athome daniele-athome self-assigned this Feb 13, 2017

@daniele-athome daniele-athome added enhancement and removed wontfix labels Feb 13, 2017

@daniele-athome daniele-athome added this to the Future milestone Feb 13, 2017

@daniele-athome

This comment has been minimized.

Copy link
Member

commented Feb 13, 2017

And it will require an internal gallery and audio/video player because files won't be available to external apps this way. Sorry I'm strongly against doing everything inside a single app. I'm ok with encrypting the messages database (#57) since that's handled internally, but building a media player and image viewer is an overkill.
However, I don't want to exclude it totally either because it's a nice security feature. I'm putting this into Future, meaning I probably won't allocate effort for this in the near future, however if someone is willing to do it...

@daniele-athome daniele-athome removed this from the Future milestone Nov 1, 2017

@daniele-athome daniele-athome removed their assignment Nov 2, 2017

@Perelandra0x309

This comment has been minimized.

Copy link

commented Jun 24, 2018

I was disappointed to see that photo data is not encrypted locally. It would not be necessary to build your own media viewers, you can have an option in Kontalk whether to automatically save media to local storage or encrypted app database and then add the ability to export media from Kontalk to the local storage. Then everything can be encrypted, but just export those items I may want to have available elsewhere.

@daniele-athome

This comment has been minimized.

Copy link
Member

commented Jul 31, 2018

It would not be necessary to build your own media viewers, you can have an option in Kontalk whether to automatically save media to local storage or encrypted app database and then add the ability to export media from Kontalk to the local storage.

This would complicate things in UX because, in order to view the full photo, the user would have to approve decrypted export to external storage so the gallery app can view it. So this would really need an internal media viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.