Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the master url to build the redirect uri in init-cloud #1701

Merged
merged 2 commits into from Jan 25, 2017
Merged

Use the master url to build the redirect uri in init-cloud #1701

merged 2 commits into from Jan 25, 2017

Conversation

kke
Copy link
Contributor

@kke kke commented Jan 23, 2017

Currently it leaves it to the master to register its own redirect-uri based on the server.root_url config.

This PR makes the CLI pass the redirect-uri when registering the master to kontena cloud.

Fixes #1697

@kke kke added this to the 1.1.0 milestone Jan 23, 2017
@kke kke self-assigned this Jan 23, 2017
@jakolehm jakolehm requested a review from nevalla January 24, 2017 11:11
nevalla
nevalla approved these changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kke kke merged commit 2c3c609 into master Jan 25, 2017
@kke kke deleted the fix/register_master_redirect_uri_in_init_cloud branch January 25, 2017 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla approved these changes

Assignees

@kke kke

Labels
cli enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kke @nevalla