Fix potential XSS vulnerability in master remote login code display #3223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.


It's possible to inject javascript into the remote login HTML page.
Exploitability is quite small, the attacker would have to trick the user to go to something like
master_url/code#code=abcd<script>alert("foo")</script>.Since the master does not have any cookie authentication and the browser won't send any bearer auth headers, the attacker would seem to have very little to gain by doing so.
One possible attack could be to display a fake cloud login screen.