Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License assign sub-command #667

Closed
jakolehm opened this issue Oct 11, 2018 · 2 comments
Closed

License assign sub-command #667

jakolehm opened this issue Oct 11, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jakolehm
Copy link
Contributor

Should exchange a valid license key to a subscription token and store it to pharos-license secret in kube-system namespace.

This replaces license-manager addon functionality.

@jakolehm jakolehm added the enhancement New feature or request label Oct 11, 2018
@jakolehm jakolehm added this to the 2.0.0 milestone Oct 11, 2018
@kke
Copy link
Contributor

kke commented Oct 16, 2018

How to update the secret?

  • A: use -c cluster.yml + ssh to retrieve kubeconfig and use it to configure k8s-client
  • B: use -c cluster.yml + ssh + remote kubectl
  • C: parse ENV['KUBECONFIG'] using Pharos::Kube::Config and use the resulting config and the current context in it to configure k8s-client

I have a working implementation of option A currently but as it's already using ssh and #668 will also rely on running the remote kubectl, maybe that should be used here too.

@kke
Copy link
Contributor

kke commented Oct 16, 2018

Switched implementation to option B, it's also a lot simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants