Skip to content

Filtering operators #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 6, 2021
Merged

Filtering operators #124

merged 5 commits into from
Jan 6, 2021

Conversation

@Simply007
Copy link
Contributor

@Simply007 Simply007 commented Dec 11, 2020 •
edited
Loading

Motivation

Fixes #106

TODO:

  • Finish remaining parametrs
  • Verify no value operators (empty, nempty)
  • Validate whether to not open and test createUrl method - let's leave it on reviewer

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Simply007 Simply007 marked this pull request as ready for review December 14, 2020 09:09
@Simply007 Simply007 requested a review from makma December 14, 2020 09:09
makma
makma approved these changes Jan 5, 2021
View reviewed changes
Copy link

@makma makma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👍

@Simply007 Simply007 merged commit ef8ae90 into master Jan 6, 2021
@Simply007 Simply007 deleted the filtering-operators branch January 6, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@makma makma makma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for new filtering operators

3 participants

@Simply007 @makma