Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to tween HSL color values #505

Closed
Jaeiya opened this issue Nov 29, 2018 · 2 comments
Closed

Unable to tween HSL color values #505

Jaeiya opened this issue Nov 29, 2018 · 2 comments
Labels
enhancement

Comments

@Jaeiya
Copy link

Jaeiya commented Nov 29, 2018 •
edited

When trying to Tween a stroke, Konva is using its Util.colorToRGBA() method, which doesn't understand HSL values. Here's the result of the conversion:
chrome_2018-11-29_13-21-33
@lavrton
Copy link
Member

lavrton commented Nov 30, 2018

Looks like our parsing does not support HSL. I guess we need to support it. As a workaround, you can convert HSL to rgba.

Anyone wants to make a PR?

@Jaeiya
Copy link
Author

Jaeiya commented Nov 30, 2018 •
edited

Yeah I converted all my values to RGB. It's not a huge deal; I use HSL for all my styles so it would just be convenient.

GeorgeGkas added a commit to GeorgeGkas/konva that referenced this issue Jul 28, 2019
@GeorgeGkas
feat(ColorToRGBA): support HSL format
5998d38 
closes issue konvajs#505
@GeorgeGkas GeorgeGkas mentioned this issue Jul 28, 2019
Merged
@lavrton lavrton closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lavrton @Jaeiya