From fbcb50286f689fc3b2749b5edfb39318ad9cf5d8 Mon Sep 17 00:00:00 2001 From: Shawn Hurley Date: Mon, 11 Mar 2024 13:52:11 -0400 Subject: [PATCH 1/2] removing testcase that finds the target, because we no longer create it by default Signed-off-by: Shawn Hurley --- analysis/tc_tackle_testapp_public.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/analysis/tc_tackle_testapp_public.go b/analysis/tc_tackle_testapp_public.go index c79ad82..7732df3 100644 --- a/analysis/tc_tackle_testapp_public.go +++ b/analysis/tc_tackle_testapp_public.go @@ -26,7 +26,7 @@ var TackleTestappPublic = TC{ }, Identities: []api.Identity{}, Analysis: api.Analysis{ - Effort: 9, + Effort: 8, Issues: []api.Issue{ { Category: "mandatory", @@ -35,12 +35,6 @@ var TackleTestappPublic = TC{ RuleSet: "discovery-rules", Rule: "hardcoded-ip-address", Incidents: []api.Incident{ - { - File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties", - Line: 2, - Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.", - CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15", - }, { File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties", Line: 2, From 144a6e1fd8b18161344de74c024f62ce4fe298b9 Mon Sep 17 00:00:00 2001 From: Shawn Hurley Date: Mon, 11 Mar 2024 16:04:51 -0400 Subject: [PATCH 2/2] fixup Signed-off-by: Shawn Hurley --- analysis/tc_tackle_testapp_public_deps.go | 14 ++++---------- .../tc_tackle_testapp_public_package_filter.go | 8 +------- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/analysis/tc_tackle_testapp_public_deps.go b/analysis/tc_tackle_testapp_public_deps.go index 33ec8af..4a10e57 100644 --- a/analysis/tc_tackle_testapp_public_deps.go +++ b/analysis/tc_tackle_testapp_public_deps.go @@ -24,7 +24,7 @@ var TackleTestappPublicWithDeps = TC{ }, Analysis: api.Analysis{ - Effort: 3, + Effort: 2, Issues: []api.Issue{ { Category: "mandatory", @@ -33,12 +33,6 @@ var TackleTestappPublicWithDeps = TC{ RuleSet: "discovery-rules", Rule: "hardcoded-ip-address", Incidents: []api.Incident{ - { - File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties", - Line: 2, - Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.", - CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15", - }, { File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties", Line: 2, @@ -55,9 +49,9 @@ var TackleTestappPublicWithDeps = TC{ Rule: "local-storage-00001", Incidents: []api.Incident{ { - File: "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java", - Line: 14, - Message: "\n An application running inside a container could lose access to a file in local storage", + File: "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java", + Line: 14, + Message: "\n An application running inside a container could lose access to a file in local storage", }, }, }, diff --git a/analysis/tc_tackle_testapp_public_package_filter.go b/analysis/tc_tackle_testapp_public_package_filter.go index d0becb3..10d502b 100644 --- a/analysis/tc_tackle_testapp_public_package_filter.go +++ b/analysis/tc_tackle_testapp_public_package_filter.go @@ -34,7 +34,7 @@ var TackleTestappPublicPackageFilter = TC{ }, }, Analysis: api.Analysis{ - Effort: 2, + Effort: 1, Issues: []api.Issue{ { Category: "mandatory", @@ -43,12 +43,6 @@ var TackleTestappPublicPackageFilter = TC{ RuleSet: "discovery-rules", Rule: "hardcoded-ip-address", Incidents: []api.Incident{ - { - File: "/addon/source/tackle-testapp-public/target/classes/persistence.properties", - Line: 2, - Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.", - CodeSnip: "jdbc.url=jdbc:oracle:thin:@10.19.2.93:15", - }, { File: "/addon/source/tackle-testapp-public/src/main/resources/persistence.properties", Line: 2,