Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs page - PatternFly Select component should be used instead of react-select #736

Open
mturley opened this issue Mar 11, 2020 · 2 comments
Open
Assignees

Comments

@mturley
Copy link
Collaborator

@mturley mturley commented Mar 11, 2020

While looking into #585, I checked for other usages of react-select outside the context of the plan wizard. It is used in LogHeader.tsx.

I'll probably take care of this in a separate PR, but if someone else does, I'll have a reference for the implementation here in my PR for #585.

Other occurrences of react-select are covered by #663, #585, #586 and #587.

@eriknelson

This comment has been minimized.

Copy link
Member

@eriknelson eriknelson commented Mar 11, 2020

Thanks Mike. Would be nice to have individual small PRs that hit each one.

@mturley

This comment has been minimized.

Copy link
Collaborator Author

@mturley mturley commented Mar 11, 2020

@eriknelson agreed. I hit just the one for the 2nd step of the plan wizard in #738. It's worth noting, in that PR I landed on a simpler string-based instance of these Select components, but for some of the others (including the Logs one I think) we'll need object values instead of just strings, and we can reference the commit I made before I simplified it: a6647e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.