Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinner is no longer experimental, we can import directly from @patternfly/react-core #737

Closed
mturley opened this issue Mar 11, 2020 · 0 comments · Fixed by #901
Closed

Spinner is no longer experimental, we can import directly from @patternfly/react-core #737

mturley opened this issue Mar 11, 2020 · 0 comments · Fixed by #901
Assignees
@gildub
Labels
low-hanging-fruit Small items good for quick fixes or new developers release-1.3.0 UXD Work requireing UX design attention

Comments

@mturley
Copy link
Collaborator

mturley commented Mar 11, 2020

I didn't want to clutter my existing PR with it, so I'm just opening this for followup:

We have this import in several places:

import { Spinner } from '@patternfly/react-core/dist/esm/experimental';

we can just import Spinner from @patternfly/react-core directly now.
@mturley mturley added low-hanging-fruit Small items good for quick fixes or new developers UXD Work requireing UX design attention labels Mar 11, 2020
@mturley mturley self-assigned this Mar 11, 2020
@jwmatthews jwmatthews assigned gildub and unassigned mturley May 29, 2020
@gildub gildub mentioned this issue Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gildub gildub

Labels
low-hanging-fruit Small items good for quick fixes or new developers release-1.3.0 UXD Work requireing UX design attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Import Spinner directly from @patternfly/react-core
3 participants
@jwmatthews @mturley @gildub