Set logo pointer to default #718
Conversation
| @@ -0,0 +1,3 @@ | |||
| .logoPointer { | |||
| cursor: default !important; | |||
There was a problem hiding this comment.
Not great we need to use !important to override these PF styles. Can we file an issue upstream and get to the bottom of why this is necessary?
I think we need to do that before this gets out of control
There was a problem hiding this comment.
On my end when I remove !important from this it still gets applied just fine. But otherwise the solution here would be to add more specificity to the selector. The cursor: pointer style is being inherited from .pf-c-page__header-brand-link so we could use .pf-c-page__header-brand-link .logoPointer to be safe.
There was a problem hiding this comment.
Oh, weird... with this style of SCSS import I'm not sure how you can even use external (non-compiled) classes in your selectors.
There was a problem hiding this comment.
Got it, there's a :global() syntax for that: #739
There was a problem hiding this comment.
@mturley The !important statements in ResultsStep.module.scss are what started my use of !important on all styles relating to patternfly. The .styledCard & .centerCard styles were working locally but were being overridden in the production image.
Closes #676