Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ingress path routing and service ports. Update cluster metadata. Change portMergeOptimizer. #195

Merged
merged 4 commits into from
Nov 11, 2020
Merged

Fix ingress path routing and service ports. Update cluster metadata. Change portMergeOptimizer. #195

merged 4 commits into from
Nov 11, 2020

Conversation

HarikrishnanBalagopal
Copy link
Contributor

No description provided.

@HarikrishnanBalagopal
updated the k8s and ibm-iks metadata. mainly for ingress v1
f2fee34 
Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>
@HarikrishnanBalagopal
upgraded to kubernetes api v1.19.3
ff1c30a 
Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>
@HarikrishnanBalagopal
changed ingress from v1beta1 to v1
5e0659c 
changed ingress path rewrite to use the new semantics.
changed service port names and numbers to match container ports.
also remove error message when war files are not found.

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>
@HarikrishnanBalagopal
changed portMergeOptimizer to ask a question if the service doesn't h…
0dc3885 
…ave any ports exposed

Signed-off-by: Harikrishnan Balagopal <Harikrishnan.Balagopal@ibm.com>
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #195 (0dc3885) into master (4d6eb00) will decrease coverage by 0.38%.
The diff coverage is 8.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
- Coverage   26.15%   25.76%   -0.39%     
==========================================
  Files          68       68              
  Lines        3957     4036      +79     
==========================================
+ Hits         1035     1040       +5     
- Misses       2836     2910      +74     
  Partials       86       86
Impacted Files Coverage Δ
internal/apiresource/service.go 0.00% <0.00%> (ø)
internal/containerizer/containerizer.go 0.00% <ø> (ø)
internal/optimizer/portmergeoptimizer.go 0.00% <0.00%> (-100.00%) ⬇️
internal/containerizer/dockerfilecontainerizer.go 57.95% <100.00%> (ø)
internal/containerizer/s2icontainerizer.go 55.55% <100.00%> (+3.55%) ⬆️
internal/source/any2kube.go 91.86% <100.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d6eb00...0dc3885. Read the comment docs.

@ashokponkumar ashokponkumar merged commit fe1cabc into konveyor:master Nov 11, 2020
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the updateclustermetadata branch November 11, 2020 19:19
@HarikrishnanBalagopal HarikrishnanBalagopal linked an issue Nov 18, 2020 that may be closed by this pull request
CF/Dockerfile: Funky character in PORT env var and duplicate containerPort elements in deployment yaml #136
Closed
@HarikrishnanBalagopal HarikrishnanBalagopal mentioned this pull request Nov 18, 2020
Closed
This was linked to issues Dec 6, 2020
Support custom ports for the backend service of an Ingress path. Support exposing multiple ports under different paths. #120
Closed
Error while deploying to ingress path validation #183
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@HarikrishnanBalagopal @ashokponkumar