fix(ag-grid-angular-theme): path to theme.scss#166
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the ng-packagr assets glob in the ag-grid-angular-theme library so the actual theme.scss is published with the package. Previously "*.scss" only matched root-level scss files and missed src/theme.scss, which is forwarded from _index.scss, breaking consumers that import the theme.
Changes:
- Replace
"*.scss"glob with explicit"_index.scss"and"src/theme.scss"entries inng-package.jsonassets.
NikGurev
approved these changes
May 15, 2026
|
Visit the preview URL for this PR (updated for commit e68215e): https://data-grid-next--data-grid-pr-166-bqgmwses.web.app (expires Wed, 20 May 2026 09:51:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.