Removed scope_source_options method and added TODO #2

Closed
wants to merge 8 commits into
from

Projects

None yet

2 participants

@KellyMahan

removed scope_source_options - not needed for azure api and just gets in the way.
Added TODO to define future development for the option of web results only or the full bing search api.

KellyMahan added some commits Aug 20, 2012
@KellyMahan KellyMahan added rvmrc file to gitignore f6dd51e
@KellyMahan KellyMahan big commit heres the details:
base_uri is different
added reserved options for skip and top
made error handling info more useful
instead of converting query to a string to send to httparty, I'm now sending a has to let it deal with it.
password is no longer hard coded and will accept direct input when calling new, or read it from your .rbing_app_id file in the $HOME directory
5d64f8f
@KellyMahan KellyMahan full 2.0.0 version bunmp 5dfd79a
@KellyMahan KellyMahan version needs to be 2.0.1 to be greater than 2.0.0.pre f9132fa
@KellyMahan KellyMahan Merge branch 'azure' of https://github.com/koppen/rbing into azure
Conflicts:
	lib/rbing.rb
e50adbe
@KellyMahan KellyMahan removed scope_source_options - not needed for azure api and just gets…
… in the way
b48187c
@KellyMahan KellyMahan added TODO item 5faf156
@KellyMahan KellyMahan matching source up with koppen/rbing/azure be1d4a3
@koppen
Owner
koppen commented Aug 21, 2012

Thanks! It looks like commit b48187c is the only commit that needs to be in this pull request, though. Please create a new pull request containing only the necessary commit.

In the future, I'd appreciate if you could create feature branches based on the working branch (currently azure) and submit pull requests from those feature branches. It makes merging your contributions way easier.

@KellyMahan

Not sure why but git thinks it needs all those commits for a successful merge. It may have to do with the original merge. And your right that a different branch would probably solve that issue in the future.

@KellyMahan

Can you manually add b48187c in your own commit. I'll blow away my project and refork to get things back in sync. From then on i'll make commits in other branches.

@koppen
Owner
koppen commented Aug 21, 2012

Done.

@koppen koppen closed this Aug 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment