Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building using gh-pages by changing to hash-based routing. #81

Merged
merged 7 commits into from Jan 18, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 17, 2021

The homepage on GitHub is https://koppor.github.io/adr-manager/. That URL has /adr-manager at the end, which is interpreted as part of the route by VueRouter.

Possible options:

  • Hard-code adr-manager as path
  • Use hash based routing.

I did not want to force the path adr-manager being hard coded, thus I changed to hash-based routing.

See History mode doc for thoughts in the history mode. Since cannot configure GitHub's web server, we need to find another way.

I hope, there is no other drawback which I overlooked.

@koppor koppor requested a review from KLBa January 17, 2021 20:25
KLBa
KLBa previously approved these changes Jan 18, 2021
Copy link
Collaborator

@KLBa KLBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of GitHub Pages!

Using hash mode is fine. (We only used history mode, because having no hash was prettier.)

@KLBa KLBa self-requested a review January 18, 2021 11:28
@KLBa KLBa dismissed their stale review January 18, 2021 11:54

needed to add tests

@KLBa KLBa merged commit 2438d1b into main Jan 18, 2021
@KLBa KLBa deleted the publish branch January 18, 2021 12:49
koppor pushed a commit that referenced this pull request Nov 10, 2021
Enable building using gh-pages by changing to hash-based routing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants