Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOI: encoded URLs should be supported #3

Closed
koppor opened this issue Nov 6, 2015 · 2 comments
Closed

DOI: encoded URLs should be supported #3

koppor opened this issue Nov 6, 2015 · 2 comments

Comments

@koppor
Copy link
Owner

@koppor koppor commented Nov 6, 2015

When building a DOI, strings like https://dx.doi.org/10.2307%2F1990888 should also be accepted

@stefan-kolb
Copy link
Collaborator

@stefan-kolb stefan-kolb commented Dec 10, 2015

I think it is not possible to identify which parts of the DOI are escaped and which are not. Where is this a problem?

@koppor
Copy link
Owner Author

@koppor koppor commented Mar 28, 2017

The DOI specifcation talks about encoding at https://www.doi.org/doi_handbook/2_Numbering.html#htmlencoding. I don't remember, where I hit the issue, but I never saw DOIs containing a real % (and not used for encoding) in the wild... Possibly, whenever the DOI is an URL (http...), decoding should be applied.

@koppor koppor closed this Feb 28, 2018
koppor pushed a commit that referenced this issue Aug 2, 2020
* upstream/master: (47 commits)
  Fix Google Scholar fetcher
  Use english for all LCID mappings JabRef#1851
  remove import preferences test mock import and convert to junit5
  fix JabRef#3693 (JabRef#3702)
  Fix space leads to jump in entry editor (JabRef#3699)
  Fix JabRef#3669
  Extract creation of the contents of FileAnnotationTabController
  Fix changelog
  Fix NPE
  Remove unnecessary file
  use processbuilder for calling external apps
  Fix color highlight of odd linked files
  Fixes JabRef#2964
  Fix koppor issues #3
  Allow spaces in DOIs
  Remove irrelevant log messages during XMP reading
  Adapt log4j configuration for cleaner junit tests JabRef#3511
  Eclipse Django style JabRef#3655
  Better code style for chained methods
  Update build.gradle
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.