Commits on Jul 15, 2010
Commits on Jul 5, 2010
  1. Show long messages and errors in a scroll view

    This stops really long sheets when the output from git is very long.
    brotherbard committed Jul 5, 2010
  2. Prettify the SSH password window

        - use something close to the standard HIG spacing
        - add the app's icon and a title so people know what app is asking for a password
        - save the position of the window and only center the window if the user hasn't moved it before
        - the NSSecureTextField spews some garbage to STDERR which GitX would show in the success/failure sheet so close STDERR
    brotherbard committed Jul 4, 2010
  3. First stab at an executable that can be put into the SSH_ASKPASS envi…

    …ronment variable to make GitX ask for passwords.
    Set the environment variables for our tool. We have a rudimentary but working password panel now. Prettification later.
    Label on password window so it's less cryptic.
    uliwitness committed with brotherbard Feb 19, 2010
  4. Update build settings to include x86_64 arch

    Set the debug configuration to NATIVE_ARCH_ACTUAL because NATIVE_ARCH will always be i386
    Move the "compile libgit2" script build phase to it's own target. By setting the script to run in it's own target we get the ability to clean it durning the clean phase (normal build phase scripts don't run during clean). This will be needed if someone has built GitX prior to this commit because the object files will be for the old architectures.
    Also give an error if there is no git repository. This is from several questions I've received after someone has downloaded the source from github instead of cloning the project. The problem is that there is no submodule setting to update.
    brotherbard committed Jul 4, 2010
  5. Select the commit as soon as it is available when updating the commit…

    … list
    This is important for large repositories as the commit will be selected when it is added instead of waiting for all the commits to be loaded.
    Stop attempts to select the current commit again if it's already selected.
    No longer need the updatedGraph property on the history list.
    brotherbard committed Jul 4, 2010
  6. Performance improvements for graphing commits

    The big improvement is reusing the PBGraphCellInfo (~8-10%)
    brotherbard committed Jul 4, 2010
  7. Update commits every 0.1 sec instead of every 1000 commits

    Slower machines will update more often and faster ones will do more work in each update.
    brotherbard committed Jul 4, 2010
Commits on Jul 4, 2010
  1. Cleanup the views when the repository window closes and stop memory l…

        - make sure to remove themselves from KV and notification center observers
        - add the PBWebHistoryController to PBHistoryController so it can be told to close
        - replaced the -removeView methods with -closeView (-removeView was not being used)
        - clear any obj-c objects set in web scripting objects
    This last item seems to be the reason that the web controllers and the current commit did not get collected which then held the repository document from being collected as well.
    brotherbard committed Jul 4, 2010
  2. Add a cleanup method to the history list.

    The cleanup method cancels any background threads and removes KV observers when the repository document is closed.
    Also removed KV observers that are no longer needed.
    brotherbard committed Jul 4, 2010
  3. Create wrapper class around git_oid and use it

    This is a convenience class to replace using NSStrings to store and compare SHAs. PBGitSHA has a much faster isEqual: function.
    It is <NSCopying> compliant and implements isEqual: and hash so it can be used as a key in dictionaries.
    brotherbard committed Jul 4, 2010
  4. Bugfix: Stop committer names from getting mangled

    If the commit's detail is not UTF8 then PBWebHistoryController's commitDetailsLoaded: method will drop down to Latin1. That can cause character's in the committer's name to not be converted correctly.
    Move parsing the name to PBGitRevList where the correct encoding can be determined.
    brotherbard committed Jul 3, 2010
  5. Bugfix: fix duplicate commits in the history view

        1) stop a threading issue with old commits being added after the commits array was reset
        2) stop using --early-output (shouldn't there be an incremental output option???)
    brotherbard committed Jul 3, 2010
  6. Fix safari 5 render issue

    pieter committed with brotherbard Jun 18, 2010
  7. Cache the lane colors

    To reduce the number of objects created and destroyed while scrolling through the history list.
    Also use a more descriptive name.
    brotherbard committed Jun 26, 2010
  8. Stop a view that was not loaded from being loaded while being removed.

    Example: If GitX started in stage view and the window was closed without ever looking at the history view, then [self view] will cause the history view's nib to be loaded which kicks off loading in the rev list. Wastes a lot of CPU cycles for no reason.
    brotherbard committed Jun 20, 2010
  9. Remove call to finalize

    brotherbard committed Jun 20, 2010
  10. Bugfix: don't remove all notifications from the web history controller

    removeObserver: removes the controller from all notifications.
    The PBWebHistoryController's super class registers it for "preferencesChangedWithNotification". This stops the controller from missing that notification and allows it to respond to changes in the preferences.
    brotherbard committed Jun 20, 2010
Commits on Jun 27, 2010
  1. Follow Commit-msg hook rules: allow it to edit the commit message, be…

    …fore committing.
    Seth Raphael committed with brotherbard May 11, 2010
  2. Bug fix: correct visible index scrolling in PBGitHistoryController an…

    …d PBCommitList.
    If the current branch filter is switched to "All" or "Local" the index that's
    calculated as being the targeted index to scroll to visible, is off by the amount
    in Y that the bottom split view separator is off from a multiple of rows.
    -adjustScroll: on PBCommitList is called automatically whenever the list needs
    laying out.
    An ivar keeps track if we come from the -scrollSelectionToTopOfViewFrom: method
    of PBGitHistoryController.
    I'll leave the commented out NSLogs in there in case they're needed for debugging
    again later.
    andreberg committed with brotherbard Apr 5, 2010
  3. Add PBStringFromBranchFilterType() function for debugging purposes to…

    … PBGitRepository.
    Add a PBGitXBranchFilterType typedef to the kGitX... branch filters enum.
    andreberg committed with brotherbard Apr 5, 2010
  4. Put at-sign in front of multi-line continued string.

    Probably doesn't matter since the compiler should concatenate both forms equally.
    andreberg committed with brotherbard Apr 5, 2010
  5. Populate the revList if empty in -commitForSHA:

    I found that at a few points logic was based on items from revList but
    at that point in the execution the revList was always empty.
    andreberg committed with brotherbard Apr 5, 2010
  6. SCNetworkCheckReachabilityByName will be deprecated anyways, so repla…

    …ce it with the docs example which will work on any OS version from 10.3.
    Modified-by: Nathan Kinsinger <>
    Released the target to stop memory leak.
    andreberg committed with brotherbard Mar 24, 2010