Namespacing everything under SteamCondenser namespace #1

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
5 participants
@reu
Contributor

reu commented Jan 2, 2012

Hi there. Don't be scare with the size of the pull request, I just moved every class/module into the SteamCondenser namespace.

The reason it did this is that some of the steam condenser classes were conflicting with my app's classes. Besides, namespacing all the classes of a gem is a very popular convention.

All the tests are passing, but maybe we should take a closer look at the WebApi classes, as the tests don't cover it all. I did some manual "navigation" through the webapi and found no errors anyway.

@koraktor

This comment has been minimized.

Show comment Hide comment
@koraktor

koraktor Jan 2, 2012

Owner

This was already on my to-do list. Thank you very much. 👍

I'll definitely merge this sooner or later, but it won't make it into master before the next version.

Owner

koraktor commented Jan 2, 2012

This was already on my to-do list. Thank you very much. 👍

I'll definitely merge this sooner or later, but it won't make it into master before the next version.

@reu

This comment has been minimized.

Show comment Hide comment
@reu

reu Jan 2, 2012

Contributor

Great!

I will keep using my repo version for while. BTW amazing library, definitively I will be helping for now on.

Contributor

reu commented Jan 2, 2012

Great!

I will keep using my repo version for while. BTW amazing library, definitively I will be helping for now on.

@koraktor

This comment has been minimized.

Show comment Hide comment
@koraktor

koraktor Jan 2, 2012

Owner

You're welcome.

I'll probably create a new feature branch for this soon. So you may want to switch to that instead.

Owner

koraktor commented Jan 2, 2012

You're welcome.

I'll probably create a new feature branch for this soon. So you may want to switch to that instead.

@koraktor

This comment has been minimized.

Show comment Hide comment
@koraktor

koraktor Jan 12, 2012

Owner

I merged your changes into namespace, so you might want to base your changes off this branch.

I hope I'll find some time to clean up and implement some other changes related to this soon.

Owner

koraktor commented Jan 12, 2012

I merged your changes into namespace, so you might want to base your changes off this branch.

I hope I'll find some time to clean up and implement some other changes related to this soon.

@koraktor koraktor referenced this pull request in koraktor/steam-condenser Apr 24, 2012

Closed

Clean namespacing for Ruby gem #158

@koraktor

This comment has been minimized.

Show comment Hide comment
@koraktor

koraktor Apr 24, 2012

Owner

Now that I have finally released verion 1.2.0 this is now top priority. Expect a rebase on master soon.

Owner

koraktor commented Apr 24, 2012

Now that I have finally released verion 1.2.0 this is now top priority. Expect a rebase on master soon.

@lunks

This comment has been minimized.

Show comment Hide comment
@lunks

lunks Nov 27, 2012

Any updates on this?

lunks commented Nov 27, 2012

Any updates on this?

@koraktor

This comment has been minimized.

Show comment Hide comment
@koraktor

koraktor Nov 27, 2012

Owner

It's still in the works, but version 1.3.0 lurks somewhere around the corner, so I'm currently focussing on this. Sorry for the added delay.

Current progress is in namespace. In fact, it's almost done.

Owner

koraktor commented Nov 27, 2012

It's still in the works, but version 1.3.0 lurks somewhere around the corner, so I'm currently focussing on this. Sorry for the added delay.

Current progress is in namespace. In fact, it's almost done.

@webdestroya

This comment has been minimized.

Show comment Hide comment
@webdestroya

webdestroya Apr 29, 2013

+1 for this, this has caused so many problems for me. I've had to name my models something random in order to not conflict

+1 for this, this has caused so many problems for me. I've had to name my models something random in order to not conflict

@Psiablo

This comment has been minimized.

Show comment Hide comment
@Psiablo

Psiablo May 24, 2013

Another +1 for this.

Psiablo commented May 24, 2013

Another +1 for this.

@koraktor

This comment has been minimized.

Show comment Hide comment
@koraktor

koraktor Jul 4, 2013

Owner

This has finally been merged into master. Thanks (especially for your patience 😏).

@lunks, @webdestroya, @Psiablo Please feel free to test this and provide feedback.

Owner

koraktor commented Jul 4, 2013

This has finally been merged into master. Thanks (especially for your patience 😏).

@lunks, @webdestroya, @Psiablo Please feel free to test this and provide feedback.

@koraktor koraktor closed this Jul 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment