Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] {pluginName}PluginMarkerMaven publication is not properly configured #167

Closed
tlinkowski opened this issue Aug 10, 2019 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@tlinkowski
Copy link
Contributor

@tlinkowski tlinkowski commented Aug 10, 2019

This continues our discussion from #96 (comment).

As far as I understand the code, {pluginName}PluginMarkerMaven is not configured by your plugins, i.e. PublishingUtils.configurePom is not called for it (it's called only for pluginMaven):
https://github.com/aalmiray/kordamp-gradle-plugins/blob/6ba1d112f2562ca140b8ef841b7448dc0c3debf4/plugins/plugin-gradle-plugin/src/main/groovy/org/kordamp/gradle/plugin/plugin/PluginPlugin.groovy#L129-L142

I worked around this by calling it on my own 🙂

@tlinkowski
Copy link
Contributor Author

@tlinkowski tlinkowski commented Aug 12, 2019

This is more complicated than I initially thought. After all, I had to remove PluginPlugin altogether because it caused my javadoc artifact to break (see tlinkowski/tlinkowski-superpom#52).

Loading

@aalmiray aalmiray self-assigned this Aug 29, 2019
@aalmiray aalmiray added the bug label Aug 29, 2019
@aalmiray aalmiray added this to the 0.30.0 milestone Nov 29, 2019
@aalmiray
Copy link
Collaborator

@aalmiray aalmiray commented Nov 29, 2019

I believe this is now covered in the latest version of the publishing plugin.

Loading

@aalmiray aalmiray closed this Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants