diff --git a/buildSrc/settings.gradle.kts b/buildSrc/settings.gradle.kts index b1d1e31da633..62991c1ef50a 100644 --- a/buildSrc/settings.gradle.kts +++ b/buildSrc/settings.gradle.kts @@ -1,7 +1,6 @@ rootProject.name = "buildSrc" dependencyResolutionManagement { - @Suppress("UnstableApiUsage") versionCatalogs { create("libs") { from(files("../gradle/libs.versions.toml")) diff --git a/buildSrc/src/main/kotlin/Compiler.kt b/buildSrc/src/main/kotlin/Compiler.kt index d0e75c32e579..382763bca8c7 100644 --- a/buildSrc/src/main/kotlin/Compiler.kt +++ b/buildSrc/src/main/kotlin/Compiler.kt @@ -1,4 +1,4 @@ -import org.jetbrains.kotlin.gradle.dsl.KotlinJvmOptions +import org.jetbrains.kotlin.gradle.dsl.KotlinJvmCompilerOptions object CompilerArguments { const val time = "-opt-in=kotlin.time.ExperimentalTime" @@ -12,13 +12,10 @@ object CompilerArguments { } object Jvm { - // keep these equivalent - const val targetString = "1.8" - const val targetInt = 8 + const val target = 8 } -fun KotlinJvmOptions.applyKordKotlinOptions() { - jvmTarget = Jvm.targetString - allWarningsAsErrors = true - freeCompilerArgs += CompilerArguments.progressive +fun KotlinJvmCompilerOptions.applyKordCompilerOptions() { + allWarningsAsErrors.set(true) + freeCompilerArgs.add(CompilerArguments.progressive) } diff --git a/buildSrc/src/main/kotlin/kord-internal-module.gradle.kts b/buildSrc/src/main/kotlin/kord-internal-module.gradle.kts index 20737779b3ff..8973472bb5f9 100644 --- a/buildSrc/src/main/kotlin/kord-internal-module.gradle.kts +++ b/buildSrc/src/main/kotlin/kord-internal-module.gradle.kts @@ -8,15 +8,12 @@ repositories { mavenCentral() } -tasks { - withType { - sourceCompatibility = Jvm.targetString - targetCompatibility = Jvm.targetString - } +kotlin { + jvmToolchain(Jvm.target) +} - withType { - kotlinOptions { - applyKordKotlinOptions() - } +tasks.withType { + compilerOptions { + applyKordCompilerOptions() } } diff --git a/buildSrc/src/main/kotlin/kord-module.gradle.kts b/buildSrc/src/main/kotlin/kord-module.gradle.kts index 02710fa90661..dd71f0562c66 100644 --- a/buildSrc/src/main/kotlin/kord-module.gradle.kts +++ b/buildSrc/src/main/kotlin/kord-module.gradle.kts @@ -1,3 +1,4 @@ +import com.google.devtools.ksp.gradle.KspTask import org.jetbrains.dokka.gradle.AbstractDokkaLeafTask import org.jetbrains.kotlin.gradle.tasks.KotlinCompile import java.net.URL @@ -19,6 +20,8 @@ repositories { kotlin { explicitApi() + jvmToolchain(Jvm.target) + sourceSets { // mark ksp src dir main { kotlin.srcDir("build/generated/ksp/main/kotlin") } @@ -34,16 +37,14 @@ atomicfu { dependenciesVersion = libs.findVersion("kotlinx-atomicfu").get().requiredVersion } -tasks { - withType { - sourceCompatibility = Jvm.targetString - targetCompatibility = Jvm.targetString - } +// the kspKotlin Task is created very late and isn't available via tasks.findByName("kspKotlin") +val kspKotlin get() = tasks.withType().matching { it.name == "kspKotlin" } +tasks { withType { - kotlinOptions { - applyKordKotlinOptions() - freeCompilerArgs += listOf( + compilerOptions { + applyKordCompilerOptions() + freeCompilerArgs.addAll( CompilerArguments.time, CompilerArguments.contracts, @@ -63,14 +64,14 @@ tasks { withType { // see https://kotlin.github.io/dokka//user_guide/gradle/usage/#configuration-options - // make sure ksp generates files before building docs - dependsOn(compileKotlin) + // include documentation generated by ksp + dependsOn(kspKotlin) failOnWarning.set(true) dokkaSourceSets.configureEach { - jdkVersion.set(Jvm.targetInt) + jdkVersion.set(Jvm.target) val baseRemoteUrl = "https://github.com/kordlib/kord/blob/${Library.commitHashOrDefault("0.8.x")}/${project.name}" @@ -106,28 +107,27 @@ tasks { } } - val sourcesJar by registering(Jar::class) { - archiveClassifier.set("sources") - from(sourceSets.main.get().allSource) + withType { + doFirst { require(!Library.isUndefined) { "No release/snapshot version found." } } } - val dokkaJar by registering(Jar::class) { - group = JavaBasePlugin.DOCUMENTATION_GROUP - description = "Assembles Kotlin docs with Dokka" - archiveClassifier.set("javadoc") - from(dokkaHtml) - dependsOn(dokkaHtml) + kotlinSourcesJar { + // include sources generated by ksp + dependsOn(kspKotlin) } +} - withType().configureEach { - doFirst { require(!Library.isUndefined) { "No release/snapshot version found." } } - } +val dokkaJar by tasks.registering(Jar::class) { + group = JavaBasePlugin.DOCUMENTATION_GROUP + description = "Assembles Kotlin docs with Dokka" + archiveClassifier.set("javadoc") + from(tasks.dokkaHtml) +} - publishing { - publications.withType { - from(components["java"]) - artifact(sourcesJar.get()) - artifact(dokkaJar.get()) - } +publishing { + publications.withType { + from(components["java"]) + artifact(tasks.kotlinSourcesJar) + artifact(dokkaJar) } } diff --git a/gradle.properties b/gradle.properties index 7583167ae78a..b28460e2ab10 100644 --- a/gradle.properties +++ b/gradle.properties @@ -6,7 +6,3 @@ kotlin.code.style=official # https://github.com/Kotlin/kotlinx-atomicfu#atomicfu-compiler-plugin kotlinx.atomicfu.enableJvmIrTransformation=true kotlinx.atomicfu.enableJsIrTransformation=true - -# remove when upgrading to gradle 8.0 -# https://docs.gradle.org/7.6/userguide/upgrading_version_7.html#strict-kotlin-dsl-precompiled-scripts-accessors -systemProp.org.gradle.kotlin.dsl.precompiled.accessors.strict=true diff --git a/gradle/wrapper/gradle-wrapper.jar b/gradle/wrapper/gradle-wrapper.jar index 943f0cbfa754..ccebba7710de 100644 Binary files a/gradle/wrapper/gradle-wrapper.jar and b/gradle/wrapper/gradle-wrapper.jar differ diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index bc073f67610a..74e2ced04e38 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,7 +1,7 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionSha256Sum=312eb12875e1747e05c2f81a4789902d7e4ec5defbd1eefeaccc08acf096505d -distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-all.zip +distributionSha256Sum=f30b29580fe11719087d698da23f3b0f0d04031d8995f7dd8275a31f7674dc01 +distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-all.zip networkTimeout=10000 zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists diff --git a/gradlew b/gradlew index 65dcd68d65c8..79a61d421cc4 100755 --- a/gradlew +++ b/gradlew @@ -144,7 +144,7 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then case $MAX_FD in #( max*) # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked. - # shellcheck disable=SC3045 + # shellcheck disable=SC3045 MAX_FD=$( ulimit -H -n ) || warn "Could not query maximum file descriptor limit" esac @@ -152,7 +152,7 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then '' | soft) :;; #( *) # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked. - # shellcheck disable=SC3045 + # shellcheck disable=SC3045 ulimit -n "$MAX_FD" || warn "Could not set maximum file descriptor limit to $MAX_FD" esac