New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page-mode rendering of tables with tall rows #119

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
3 participants
@poire-z
Contributor

poire-z commented Mar 8, 2018

Fix bug reported at #102 (comment)

Any tall row (row height higher than page height) in a table could mess the rendering of the few first rows.
(Because of a typo in lvrend.cpp: the emptycontext was created for that purpose, but the author just forgot to use it on the next line).

Also, such tall row content would be truncated to the page height and the overflowed content would
simply not be displayed. So, added SplitLineIfOverflowPage() to deal with such rows.

Sample file for testing before/after, made out from the chapter in question from @Eduardomb22 's book, plus some added tests with (randomly found) tall images.
Thsi PR just fix the page mode rendering, so no part of the content (as displayed in scroll mode) is lost when in page mode (the choice of where to split rows on pages, or image size scaling in table or page, may sometime feel like it could be better, but that's not the object of this PR :)

Fix page-mode rendering of tables with tall rows
Any tall row (row higher than page height) in a table
could mess with the rendering of the few first rows.
Also, such tall row content would be truncated to
the page height and the overflowed content would
simply not be displayed.
@Eduardomb22

This comment has been minimized.

Eduardomb22 commented Mar 8, 2018

Thanks for the fix!

@Frenzie

Frenzie approved these changes Mar 8, 2018

Looks ok.

@poire-z poire-z merged commit 21b011b into koreader:master Mar 9, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@poire-z poire-z deleted the poire-z:fix_table_tall_rows_rendering branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment